using :delta-reasoning? instead od :reasoning-content

Author: zikajk

src/eca/features/chat.clj

@@ -1142,7 +1142,7 @@
                                          (add-to-history! {:role "reason"
                                                            :content {:id id
                                                                      :external-id external-id
-                                                                     :reasoning-content reasoning-content
+                                                                     :delta-reasoning? (some? reasoning-content)
                                                                      :total-time-ms total-time-ms
                                                                      :text (get-in @reasonings* [id :text])}})
                                          (send-content! chat-ctx :assistant {:type :reasonFinished :total-time-ms total-time-ms :id id})))

src/eca/llm_providers/openai_chat.clj

@@ -153,10 +153,10 @@
                         :content (llm-util/stringfy-tool-result content)}
     "user" {:role "user"
             :content (extract-content content supports-image?)}
-    "reason" (if-let [reasoning-content (:reasoning-content content)]
+    "reason" (if (:delta-reasoning? content)
                ;; DeepSeek-style: reasoning_content must be passed back to API
                {:role "assistant"
-                :reasoning_content reasoning-content}
+                :reasoning_content (:text content)}
                ;; Fallback: wrap in thinking tags for models that use text-based reasoning
                {:role "assistant"
                 :content [{:type "text"
@@ -323,14 +323,14 @@
 
 (defn ^:private prune-history
   "Ensure DeepSeek-style reasoning_content is discarded from history but kept for the active turn.
-   Only drops 'reason' messages WITH :reasoning-content before the last user message.
-   Think-tag based reasoning (without :reasoning-content) is preserved and transformed to assistant messages."
+   Only drops 'reason' messages WITH :delta-reasoning? before the last user message.
+   Think-tag based reasoning (without :delta-reasoning?) is preserved and transformed to assistant messages."
   [messages]
   (if-let [last-user-idx (llm-util/find-last-user-msg-idx messages)]
     (->> messages
          (keep-indexed (fn [i m]
                          (when-not (and (= "reason" (:role m))
-                                        (get-in m [:content :reasoning-content])
+                                        (get-in m [:content :delta-reasoning?])
                                         (< i last-user-idx))
                            m)))
          vec)

test/eca/llm_providers/openai_chat_test.clj

@@ -117,8 +117,8 @@
           thinking-start-tag
           thinking-end-tag))))
 
-  (testing "Reason messages - use reasoning_content if present, otherwise tags"
-    ;; Without :reasoning-content, uses think tags
+  (testing "Reason messages - use reasoning_content if :delta-reasoning?, otherwise tags"
+    ;; Without :delta-reasoning?, uses think tags
     (is (match?
          {:role "assistant"
           :content [{:type "text" :text "<think>Reasoning...</think>"}]}
@@ -128,14 +128,14 @@
           true
           thinking-start-tag
           thinking-end-tag)))
-    ;; With :reasoning-content, uses reasoning_content field
+    ;; With :delta-reasoning?, uses reasoning_content field with :text value
     (is (match?
          {:role "assistant"
-          :reasoning_content "opaque"}
+          :reasoning_content "Reasoning..."}
          (#'llm-providers.openai-chat/transform-message
           {:role "reason"
            :content {:text "Reasoning..."
-                     :reasoning-content "opaque"}}
+                     :delta-reasoning? true}}
           true
           thinking-start-tag
           thinking-end-tag))))
@@ -193,22 +193,22 @@
            {:role "assistant" :reasoning_content "Thinking..."}])))))
 
 (deftest prune-history-test
-  (testing "Drops reason messages WITH reasoning-content before the last user message (DeepSeek)"
+  (testing "Drops reason messages WITH :delta-reasoning? before the last user message (DeepSeek)"
     (is (match?
          [{:role "user" :content "Q1"}
           {:role "assistant" :content "A1"}
           {:role "user" :content "Q2"}
-          {:role "reason" :content {:text "r2" :reasoning-content "e2"}}
+          {:role "reason" :content {:text "r2" :delta-reasoning? true}}
           {:role "assistant" :content "A2"}]
          (#'llm-providers.openai-chat/prune-history
           [{:role "user" :content "Q1"}
-           {:role "reason" :content {:text "r1" :reasoning-content "e1"}}
+           {:role "reason" :content {:text "r1" :delta-reasoning? true}}
            {:role "assistant" :content "A1"}
            {:role "user" :content "Q2"}
-           {:role "reason" :content {:text "r2" :reasoning-content "e2"}}
+           {:role "reason" :content {:text "r2" :delta-reasoning? true}}
            {:role "assistant" :content "A2"}]))))
 
-  (testing "Preserves reason messages WITHOUT reasoning-content (think-tag based)"
+  (testing "Preserves reason messages WITHOUT :delta-reasoning? (think-tag based)"
     (is (match?
          [{:role "user" :content "Q1"}
           {:role "reason" :content {:text "thinking..."}}
@@ -249,12 +249,12 @@
 (deftest external-id-test
   (testing "Tool call with external-id is preserved"
     (is (match?
-         {:type :tool-call
-          :data {:id "call-123"
-                 :type "function"
-                 :function {:name "eca__get_weather"
-                            :arguments "{\"location\":\"Paris\"}"}
-                 :extra_content {:google {:thought_signature "signature-abc-123"}}}}
+         {:role "assistant"
+          :tool_calls [{:id "call-123"
+                        :type "function"
+                        :function {:name      "eca__get_weather"
+                                   :arguments "{\"location\":\"Paris\"}"}
+                        :extra_content {:google {:thought_signature "signature-abc-123"}}}]}
          (#'llm-providers.openai-chat/transform-message
           {:role "tool_call"
            :content {:id "call-123"
@@ -373,15 +373,17 @@
       (is (not @on-reason-called?) "on-reason should not be called when :id is nil"))))
 
 (deftest deepseek-non-stream-reasoning-content-test
-  (testing "response-body->result captures reasoning_content and normalization preserves it"
+  (testing "response-body->result captures reasoning_content and normalization uses :text with :delta-reasoning?"
     (let [body {:usage {:prompt_tokens 5 :completion_tokens 2}
                 :choices [{:message {:content "hi"
                                      :reasoning_content "think more"}}]}
           result (#'llm-providers.openai-chat/response-body->result body (fn [& _]))
+          ;; Simulate how chat.clj would store this: :text has the content, :delta-reasoning? is the flag
           normalized (#'llm-providers.openai-chat/normalize-messages
                       [{:role "user" :content "Q"}
                        {:role "reason" :content {:id "r1"
-                                                 :reasoning-content (:reasoning-content result)}}]
+                                                 :text (:reasoning-content result)
+                                                 :delta-reasoning? true}}]
                       true
                       thinking-start-tag
                       thinking-end-tag)]