Fix arguments text when preparing tool call

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Fix arguments test when preparing tool call.
+
 ## 0.4.0
 
 - Add support for global rules.

docs/protocol.md

@@ -517,7 +517,7 @@ interface ToolCallPrepareContent {
     /*
      * Argument text of this tool call
      */
-    argumentText: string;
+    argumentsText: string;
 
     /**
      * Whether this call requires manual approval from the user.
@@ -546,7 +546,7 @@ interface ToolCallRunContent {
     /*
      * Arguments of this tool call
      */
-    arguments: string[];
+    arguments: {[key: string]: string};
 
     /**
      * Whether this call requires manual approval from the user.

src/eca/features/chat.clj

@@ -178,7 +178,7 @@
                                :finish (do
                                          (add-to-history! {:role "assistant" :content @received-msgs*})
                                          (finish-chat-prompt! chat-id :idle messenger db*))))
-      :on-prepare-tool-call (fn [{:keys [id name argument]}]
+      :on-prepare-tool-call (fn [{:keys [id name arguments-text]}]
                               (assert-chat-not-stopped! chat-id db* messenger)
                               (messenger/chat-content-received
                                messenger
@@ -188,7 +188,7 @@
                                 :content {:type :toolCallPrepare
                                           :name name
                                           :origin (tool-name->origin name all-tools)
-                                          :argumentText argument
+                                          :arguments-text arguments-text
                                           :id id
                                           :manual-approval false}}))
       :on-tool-called (fn [{:keys [id name arguments] :as tool-call}]

src/eca/llm_providers/anthropic.clj

@@ -104,7 +104,7 @@
                                     "tool_use" (do
                                                  (on-prepare-tool-call {:name (-> data :content_block :name)
                                                                         :id (-> data :content_block :id)
-                                                                        :argumentsText ""})
+                                                                        :arguments-text ""})
                                                  (swap! content-block* assoc (:index data) (:content_block data)))
 
                                     nil)
@@ -116,7 +116,7 @@
                                                              content-block (get @content-block* (:index data))]
                                                          (on-prepare-tool-call {:name (:name content-block)
                                                                                 :id (:id content-block)
-                                                                                :argumentsText text}))
+                                                                                :arguments-text text}))
                                     "citations_delta" (case (-> data :delta :citation :type)
                                                         "web_search_result_location" (on-message-received
                                                                                       {:type :url

src/eca/llm_providers/ollama.clj

@@ -96,7 +96,7 @@
                                    tool-call {:id call-id
                                               :name (:name function)
                                               :arguments (:arguments function)}]
-                               (on-prepare-tool-call (assoc tool-call :argumentsText ""))
+                               (on-prepare-tool-call (assoc tool-call :arguments-text ""))
                                (swap! tool-calls* assoc rid tool-call))
 
                              done_reason

src/eca/llm_providers/openai.clj

@@ -85,7 +85,7 @@
             "response.function_call_arguments.delta" (let [call (get @mcp-call-by-item-id* (:item_id data))]
                                                        (on-prepare-tool-call {:id (:id call)
                                                                               :name (:name call)
-                                                                              :argumentsText (:delta data)}))
+                                                                              :arguments-text (:delta data)}))
 
             "response.output_item.done"
             (case (:type (:item data))
@@ -124,7 +124,7 @@
                                 (swap! mcp-call-by-item-id* assoc item-id {:name name :id call-id})
                                 (on-prepare-tool-call {:id (-> data :item :call_id)
                                                        :name (-> data :item :name)
-                                                       :argumentsText (-> data :item :arguments)}))
+                                                       :arguments-text (-> data :item :arguments)}))
               nil)
 
             ;; done

test/eca/features/chat_test.clj

@@ -212,7 +212,7 @@ for allowed directories and then list files"
               (on-first-response-received {:type :text :text "Ok,"})
               (on-message-received {:type :text :text "Ok,"})
               (on-message-received {:type :text :text " working on it"})
-              (on-prepare-tool-call {:id "call-1" :name "list_allowed_directories" :argumentsText ""})
+              (on-prepare-tool-call {:id "call-1" :name "list_allowed_directories" :arguments-text ""})
               (on-tool-called {:id "call-1" :name "list_allowed_directories" :arguments {}})
               (on-message-received {:type :text :text "I can see: \n"})
               (on-message-received {:type :text :text "/foo/bar"})
@@ -237,7 +237,7 @@ for allowed directories and then list files"
              {:role :system :content {:type :progress :state :running :text "Generating"}}
              {:role :assistant :content {:type :text :text "Ok,"}}
              {:role :assistant :content {:type :text :text " working on it"}}
-             {:role :assistant :content {:type :toolCallPrepare :id "call-1" :name "list_allowed_directories" :argumentText nil :manual-approval false}}
+             {:role :assistant :content {:type :toolCallPrepare :id "call-1" :name "list_allowed_directories" :arguments-text "" :manual-approval false}}
              {:role :assistant :content {:type :toolCallRun :id "call-1" :name "list_allowed_directories" :arguments {} :manual-approval false}}
              {:role :assistant :content {:type :toolCalled :id "call-1" :name "list_allowed_directories" :arguments {} :outputs [{:content "Allowed directories: /foo/bar" :error false :type :text}]}}
              {:role :assistant :content {:type :text :text "I can see: \n"}}