Fix renew token regression.

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Fix renew token regression.
+- Improve error feedback when failed to renew token.
+
 ## 0.44.0
 
 - Support `deny` tool calls via `toolCall approval deny` setting.

src/eca/features/chat.clj

@@ -129,7 +129,12 @@
         (send-content! chat-ctx :system {:type :progress
                                          :state :running
                                          :text "Renewing auth token"})
-        (f.login/renew-auth! provider db*)))
+        (f.login/renew-auth! provider chat-ctx
+                             {:on-error (fn [error-msg]
+                                          (send-content! chat-ctx :system {:type :text
+                                                                           :text error-msg})
+                                          (finish-chat-prompt! :idle chat-ctx)
+                                          (throw (ex-info "Auth token renew failed" {})))})))
 
     (send-content! chat-ctx :system {:type :progress
                                      :state :running

src/eca/features/login.clj

@@ -49,18 +49,26 @@
       :content {:type :text
                 :text (str input "\n")}})
     (login-step ctx)
-    (db/update-global-cache! @db*)
     {:chat-id chat-id
      :status step}))
 
-(defn renew-auth! [provider db*]
-  (login-step
-   {:provider provider
-    :step :login/renew-token
-    :db* db*})
-  (db/update-global-cache! @db*))
+(defn renew-auth!
+  [provider
+   {:keys [db* messenger config]}
+   {:keys [on-error]}]
+  (try
+    (login-step
+     {:provider provider
+      :messenger messenger
+      :config config
+      :step :login/renew-token
+      :db* db*})
+    (db/update-global-cache! @db*)
+    (catch Exception e
+      (on-error (.getMessage e)))))
 
 (defn login-done! [{:keys [db* config messenger]}]
+  (db/update-global-cache! @db*)
   (models/sync-models! db*
                        config
                        (fn [new-models]