Improve error handling

Author: ericdallo

src/eca/features/chat.clj

@@ -92,15 +92,15 @@
                                                    :is-complete (boolean finish-reason)
                                                    :content {:type :text
                                                              :text message}}))
-                          :on-error (fn [e]
+                          :on-error (fn [{:keys [message exception]}]
                                       (messenger/chat-content-received
                                        messenger
                                        {:chat-id chat-id
                                         :request-id request-id
                                         :is-complete true
                                         :role :system
                                         :content {:type :text
-                                                  :text (str "\nError: " (ex-message e))}}))}))
+                                                  :text (or message (ex-message exception))}}))}))
     {:chat-id chat-id
      :status :success}))
 

src/eca/llm_api.clj

@@ -16,4 +16,4 @@
                  :api-key (:openai-api-key config)}
                 {:on-message-received on-message-received
                  :on-error on-error})
-    (on-error (str "Unsupported model: " model))))
+    (on-error {:msg (str "ECA Unsupported model: " model)})))

src/eca/llm_providers/openai.clj

@@ -3,8 +3,11 @@
    [cheshire.core :as json]
    [clojure.java.io :as io]
    [clojure.string :as str]
+   [eca.logger :as logger]
    [hato.client :as http]))
 
+(def ^:private logger-tag "[OPENAI]")
+
 (def ^:private url "https://api.openai.com/v1/chat/completions")
 
 (defn ^:private raw-data->messages [data]
@@ -29,12 +32,15 @@
      {:headers {"Authorization" (str "Bearer " api-key)
                 "Content-Type" "application/json"}
       :body (json/generate-string body)
+      :throw-exceptions? false
       :async? true
       :as :stream}
      (fn [{:keys [status body]}]
        (try
          (if (not= 200 status)
-           (on-error status)
+           (do
+             (logger/warn logger-tag "Unexpected response status" status)
+             (on-error {:message (str "OpenAI response status: " status)}))
            (with-open [rdr (io/reader body)]
              (doseq [line (line-seq rdr)]
                (when (str/starts-with? line "data: ")
@@ -43,7 +49,6 @@
                      (doseq [message (raw-data->messages data)]
                        (on-message-received message))))))))
          (catch Exception e
-           ;; TODO improve error handling
-           (println "-->" e))))
+           (on-error {:exception e}))))
      (fn [e]
-       (on-error e)))))
+       (on-error {:exception e})))))

src/eca/logger.clj

@@ -1,10 +1,16 @@
 (ns eca.logger)
 
-;; TODO create better logger capability.
-(defn info [& args]
+(defn ^:private stderr-print [& args]
   (binding [*out* *err*]
     (apply println args)))
 
+;; TODO create better logger capability.
+(defn info [& args]
+  (apply stderr-print args))
+
+(defn warn [& args]
+  (apply stderr-print args))
+
 (defn format-time-delta-ms [start-time end-time]
   (format "%.0fms" (float (/ (- end-time start-time) 1000000))))