Fix lines range parse on user prompt contexts

Author: ericdallo

CHANGELOG.md

@@ -1,7 +1,9 @@
 # Changelog
 
 ## Unreleased
+
 - Improved `eca_edit_file` to automatically handle whitespace and indentation differences in single-occurrence edits.
+- Fix contexts in user prompts (not system contexts) not parsing lines ranges properly.
 
 ## 0.73.5
 

src/eca/features/context.clj

@@ -88,7 +88,7 @@
        {:type :file
         :path path
         :content (llm-api/refine-file-context path lines-range)}
-       :partial lines-range))))
+       :partial (some? lines-range)))))
 
 (defn raw-contexts->refined [contexts db]
   (mapcat (fn [{:keys [type path lines-range position uri]}]
@@ -117,17 +117,19 @@
           contexts))
 
 (defn contexts-str-from-prompt
-  "Extract all contexts (@something) and refine them."
+  "Extract all contexts (@something) and refine them.
+   Parse lines if present in contexts like @/path/to/file:L1-L4"
   [prompt db]
-  (let [context-pattern #"[@]([^\s]+)"
+  (let [;; Capture @<path> with optional :L<start>-L<end>
+        context-pattern #"@([^\s:]+)(?::L(\d+)-L(\d+))?"
         matches (re-seq context-pattern prompt)]
     (when (seq matches)
-      (let [raw-contexts (mapv (fn [[full-match path]]
-                                 (let [type (if (string/starts-with? full-match "@")
-                                              "file"
-                                              "file")]
-                                   {:type type
-                                    :path path}))
+      (let [raw-contexts (mapv (fn [[_ path s e]]
+                                 (assoc-some {:type "file"
+                                              :path path}
+                                             :lines-range (when (and s e)
+                                                            {:start (Integer/parseInt s)
+                                                             :end (Integer/parseInt e)})))
                                matches)]
         (raw-contexts->refined raw-contexts db)))))
 

test/eca/features/context_test.clj

@@ -321,3 +321,24 @@
                 :path b-file
                 :content b-content}])
              (#'f.context/parse-agents-file a-file)))))))
+
+(deftest contexts-str-from-prompt-test
+  (testing "not context mention"
+    (is (match?
+         nil
+         (f.context/contexts-str-from-prompt "check /path/to/file" (h/db)))))
+  (testing "Context mention"
+    (with-redefs [llm-api/refine-file-context (constantly "Some content")]
+      (is (match?
+           [{:type :file
+             :path (h/file-path "/path/to/file")
+             :content "Some content"}]
+           (f.context/contexts-str-from-prompt "check @/path/to/file" (h/db))))))
+  (testing "Context mention with lines range"
+    (with-redefs [llm-api/refine-file-context (constantly "Some content")]
+      (is (match?
+           [{:type :file
+             :path (h/file-path "/path/to/file")
+             :partial true
+             :content "Some content"}]
+           (f.context/contexts-str-from-prompt "check @/path/to/file:L1-L4" (h/db)))))))