Fix regression in /compact command.

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Fix regression in `/compact` command.
+
 ## 0.71.1
 
 - Use web-search false if model capabiltiies are not found.

src/eca/features/chat.clj

@@ -697,7 +697,7 @@
                                                    ;; assert: In :executing
                                                    (logger/debug logger-tag "Just set up the call promise"
                                                                  {:tool-call-id id})
-                                                   (let [result (f.tools/call-tool! name arguments behavior chat-id id db* config messenger metrics
+                                                   (let [result (f.tools/call-tool! name arguments chat-id id behavior db* config messenger metrics
                                                                                     (partial get-tool-call-state @db* chat-id id)
                                                                                     (partial transition-tool-call! db* chat-ctx id))
                                                          details (f.tools/tool-call-details-after-invocation name arguments details result)

src/eca/features/commands.clj

@@ -205,11 +205,12 @@
                   {:type :send-prompt
                    :on-finished-side-effect (fn []
                                               ;; Replace chat history with summary
-                                              (swap! db* assoc-in [:chats chat-id :messages]
-                                                     [{:role "user"
-                                                       :content [{:type :text
-                                                                  :text (str "The conversation was compacted/summarized, consider this summary:\n"
-                                                                             (get-in @db* [:chats chat-id :last-summary]))}]}])
+                                              (swap! db* (fn [db]
+                                                           (assoc-in db [:chats chat-id :messages]
+                                                                     [{:role "user"
+                                                                       :content [{:type :text
+                                                                                  :text (str "The conversation was compacted/summarized, consider this summary:\n"
+                                                                                             (get-in db [:chats chat-id :last-summary]))}]}])))
 
                                               ;; Zero chat usage
                                               (swap! db* assoc-in [:chats chat-id :total-input-tokens] nil)

src/eca/features/tools/chat.clj

@@ -12,7 +12,7 @@
     ;; Save summary to replace chat history later
     (swap! db* assoc-in [:chats chat-id :last-summary] summary)
 
-    (tools.util/single-text-content summary)))
+    (tools.util/single-text-content "Compacted successfully!")))
 
 (def definitions
   {"eca_compact_chat"

test/eca/features/tools/chat_test.clj

@@ -20,7 +20,7 @@
                     {:db* db* :chat-id chat-id})]
         (testing "returns correct response format"
           (is (match?
-               {:contents [{:type :text :text test-summary}]}
+               {:contents [{:type :text :text "Compacted successfully!"}]}
                result)))
 
         (testing "updates database state correctly"
@@ -40,29 +40,12 @@
                     {"summary" empty-summary}
                     {:db* db* :chat-id chat-id})]
         (is (match?
-             {:contents [{:type :text :text empty-summary}]}
+             {:contents [{:type :text :text "Compacted successfully!"}]}
              result))
 
         (let [chat-state (get-in @db* [:chats chat-id])]
           (is (= false (:compacting? chat-state)))
-          (is (= empty-summary (:last-summary chat-state)))))))
-
-  (testing "Handles missing summary parameter gracefully"
-    (let [db* (h/db*)
-          chat-id "test-chat-789"]
-      (swap! db* assoc-in [:chats chat-id :compacting?] true)
-      
-      ;; This should not throw, but handle the missing parameter
-      (try
-        (let [result ((get-in f.tools.chat/definitions ["eca_compact_chat" :handler])
-                      {}
-                      {:db* db* :chat-id chat-id})]
-          (is (match?
-               {:contents [{:type :text :text nil}]}
-               result)))
-        (catch Exception _
-          ;; If it throws, that's also acceptable behavior for missing required parameter
-          (is true "Exception is acceptable for missing required parameter"))))))
+          (is (= empty-summary (:last-summary chat-state))))))))
 
 (deftest compact-chat-enabled-test
   (testing "Tool is enabled when chat is compacting"