Support ~ in dynamic string parser.

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Support `~` in dynamic string parser.
+
 ## 0.86.0
 
 - Improve agent behavior prompt to mention usage of editor_diagnostics tool. #230

src/eca/config.clj

@@ -159,11 +159,12 @@
           (string/replace #"\$\{file:([^}]+)\}"
                           (fn [[_match file-path]]
                             (try
-                              (slurp (str (if (fs/absolute? file-path)
-                                            file-path
-                                            (if cwd
-                                              (fs/path cwd file-path)
-                                              (fs/path file-path)))))
+                              (let [file-path (fs/expand-home file-path)]
+                                (slurp (str (if (fs/absolute? file-path)
+                                              file-path
+                                              (if cwd
+                                                (fs/path cwd file-path)
+                                                (fs/path file-path))))))
                               (catch Exception _
                                 (logger/warn logger-tag "File not found when parsing string:" s)
                                 ""))))

test/eca/config_test.clj

@@ -7,7 +7,8 @@
    [eca.logger :as logger]
    [eca.secrets :as secrets]
    [eca.test-helper :as h]
-   [matcher-combinators.test :refer [match?]]))
+   [matcher-combinators.test :refer [match?]]
+   [clojure.string :as string]))
 
 (h/reset-components-before-test)
 
@@ -282,6 +283,17 @@
                             (throw (ex-info "File not found" {}))))]
       (is (= "relative file content" (#'config/parse-dynamic-string "${file:test.txt}" "/tmp" {})))))
 
+  (testing "replaces file pattern with file content - path with ~"
+    (with-redefs [fs/absolute? (fn [_] true)
+                  fs/path (fn [cwd file-path] (str cwd "/" file-path))
+                  fs/expand-home (fn [f]
+                                   (string/replace (str f) "~" "/home/user"))
+                  slurp (fn [path]
+                          (if (= path "/home/user/foo/test.txt")
+                            "relative file content"
+                            (throw (ex-info "File not found" {}))))]
+      (is (= "relative file content" (#'config/parse-dynamic-string "${file:~/foo/test.txt}" "/tmp" {})))))
+
   (testing "replaces file pattern with empty string when file not found"
     (with-redefs [logger/warn (fn [& _] nil)
                   fs/absolute? (fn [_] true)