Fix test

Author: ericdallo

src/eca/features/commands.clj

@@ -10,7 +10,6 @@
    [eca.features.prompt :as f.prompt]
    [eca.features.tools.mcp :as f.mcp]
    [eca.llm-api :as llm-api]
-   [eca.logger :as logger]
    [eca.messenger :as messenger]
    [eca.secrets :as secrets]
    [eca.shared :as shared :refer [multi-str update-some]])

test/eca/features/tools/filesystem_test.clj

@@ -378,78 +378,78 @@
            ((get-in f.tools.filesystem/definitions ["eca_move_file" :handler])
             {"source" (h/file-path "/foo/bar/some_file.clj")
              "destination" (h/file-path "/foo/bar/other_file.clj")}
-            {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}})))))
+            {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))))
 
-  (deftest preview-file-change-test
-    (testing "Preview does not modify files"
-      (let [spit-called* (atom false)
-            original-file-content "line1\nline2\nline3"]
-        (is (match?
-             {:error false
-              :contents [{:type :text
-                          :text (format "Change simulation completed for %s. Original file unchanged - preview only." (h/file-path "/foo/bar/my-file.txt"))}]}
-             (with-redefs [fs/exists? (constantly true)
-                           fs/readable? (constantly true)
-                           f.tools.filesystem/allowed-path? (constantly true)
-                           slurp (constantly original-file-content)
-                           spit (fn [& _] (reset! spit-called* true))]
-               ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
-                {"path" (h/file-path "/foo/bar/my-file.txt")
-                 "original_content" "line2"
-                 "new_content" "modified line2"}
-                {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
+(deftest preview-file-change-test
+  (testing "Preview does not modify files"
+    (let [spit-called* (atom false)
+          original-file-content "line1\nline2\nline3"]
+      (is (match?
+           {:error false
+            :contents [{:type :text
+                        :text (format "Change simulation completed for %s. Original file unchanged - preview only." (h/file-path "/foo/bar/my-file.txt"))}]}
+           (with-redefs [fs/exists? (constantly true)
+                         fs/readable? (constantly true)
+                         f.tools.filesystem/allowed-path? (constantly true)
+                         slurp (constantly original-file-content)
+                         spit (fn [& _] (reset! spit-called* true))]
+             ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
+              {"path" (h/file-path "/foo/bar/my-file.txt")
+               "original_content" "line2"
+               "new_content" "modified line2"}
+              {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
       ;; Verify that spit was never called (no file modification)
-        (is (false? @spit-called*))))
+      (is (false? @spit-called*))))
 
-    (testing "Preview handles content not found"
-      (let [spit-called* (atom false)]
-        (is (match?
-             {:error true
-              :contents [{:type :text
-                          :text (format "Original content not found in %s" (h/file-path "/foo/bar/my-file.txt"))}]}
-             (with-redefs [fs/exists? (constantly true)
-                           fs/readable? (constantly true)
-                           f.tools.filesystem/allowed-path? (constantly true)
-                           slurp (constantly "line1\nline2\nline3")
-                           spit (fn [& _] (reset! spit-called* true))]
-               ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
-                {"path" (h/file-path "/foo/bar/my-file.txt")
-                 "original_content" "notfound"
-                 "new_content" "new"}
-                {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
+  (testing "Preview handles content not found"
+    (let [spit-called* (atom false)]
+      (is (match?
+           {:error true
+            :contents [{:type :text
+                        :text (format "Original content not found in %s" (h/file-path "/foo/bar/my-file.txt"))}]}
+           (with-redefs [fs/exists? (constantly true)
+                         fs/readable? (constantly true)
+                         f.tools.filesystem/allowed-path? (constantly true)
+                         slurp (constantly "line1\nline2\nline3")
+                         spit (fn [& _] (reset! spit-called* true))]
+             ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
+              {"path" (h/file-path "/foo/bar/my-file.txt")
+               "original_content" "notfound"
+               "new_content" "new"}
+              {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
       ;; Verify that spit was never called even for error case
-        (is (false? @spit-called*))))
+      (is (false? @spit-called*))))
 
-    (testing "Preview succeeds for new file creation (empty original content)"
-      (let [spit-called* (atom false)]
-        (is (match?
-             {:error false
-              :contents [{:type :text
-                          :text (format "New file creation simulation completed for %s. File will be created - preview only." (h/file-path "/foo/bar/new-file.txt"))}]}
-             (with-redefs [fs/exists? (constantly false)  ; File doesn't exist
-                           f.tools.filesystem/allowed-path? (constantly true)
-                           spit (fn [& _] (reset! spit-called* true))]
-               ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
-                {"path" (h/file-path "/foo/bar/new-file.txt")
-                 "original_content" ""  ; Empty for new file
-                 "new_content" "New file content"}
-                {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
+  (testing "Preview succeeds for new file creation (empty original content)"
+    (let [spit-called* (atom false)]
+      (is (match?
+           {:error false
+            :contents [{:type :text
+                        :text (format "New file creation simulation completed for %s. File will be created - preview only." (h/file-path "/foo/bar/new-file.txt"))}]}
+           (with-redefs [fs/exists? (constantly false)  ; File doesn't exist
+                         f.tools.filesystem/allowed-path? (constantly true)
+                         spit (fn [& _] (reset! spit-called* true))]
+             ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
+              {"path" (h/file-path "/foo/bar/new-file.txt")
+               "original_content" ""  ; Empty for new file
+               "new_content" "New file content"}
+              {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
       ;; Verify that spit was never called (no file modification)
-        (is (false? @spit-called*))))
+      (is (false? @spit-called*))))
 
-    (testing "Preview fails when trying to find content in non-existent file"
-      (let [spit-called* (atom false)]
-        (is (match?
-             {:error true
-              :contents [{:type :text
-                          :text (format "Preview error for %s: For new files, original_content must be empty string (\"\"). Use markdown blocks during exploration, then eca_preview_file_change for final implementation only." (h/file-path "/foo/bar/missing-file.txt"))}]}
-             (with-redefs [fs/exists? (constantly false)  ; File doesn't exist
-                           f.tools.filesystem/allowed-path? (constantly true)
-                           spit (fn [& _] (reset! spit-called* true))]
-               ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
-                {"path" (h/file-path "/foo/bar/missing-file.txt")
-                 "original_content" "some content"  ; Non-empty for non-existent file
-                 "new_content" "replacement content"}
-                {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
+  (testing "Preview fails when trying to find content in non-existent file"
+    (let [spit-called* (atom false)]
+      (is (match?
+           {:error true
+            :contents [{:type :text
+                        :text (format "Preview error for %s: For new files, original_content must be empty string (\"\"). Use markdown blocks during exploration, then eca_preview_file_change for final implementation only." (h/file-path "/foo/bar/missing-file.txt"))}]}
+           (with-redefs [fs/exists? (constantly false)  ; File doesn't exist
+                         f.tools.filesystem/allowed-path? (constantly true)
+                         spit (fn [& _] (reset! spit-called* true))]
+             ((get-in f.tools.filesystem/definitions ["eca_preview_file_change" :handler])
+              {"path" (h/file-path "/foo/bar/missing-file.txt")
+               "original_content" "some content"  ; Non-empty for non-existent file
+               "new_content" "replacement content"}
+              {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}}))))
       ;; Verify that spit was never called
-        (is (false? @spit-called*))))))
+      (is (false? @spit-called*)))))