docs + remove search-files tool

Author: ericdallo

docs/features.md

@@ -19,12 +19,11 @@ Some native tools like `filesystem` have MCP alternatives, but ECA having them b
 
 Provides access to filesystem under workspace root, listing and reading files and directories a subset of [official MCP filesystem](https://mcpserverhub.com/servers/filesystem), important for agentic operations, without the need to support NPM or other tools.
 
+- `eca_directory_tree`: list a directory as a tree (can be recursive).
 - `eca_read_file`: read a file content.
 - `eca_write_file`: write content to a new file.
 - `eca_edit_file`: replace lines of a file with a new content.
 - `eca_move_file`: move/rename a file.
-- `eca_list_directory`: list a directory.
-- `eca_search_files`: search in a path for files matching a pattern.
 - `eca_grep`: ripgrep/grep for paths with specified content.
 
 #### Shell

src/eca/features/tools/filesystem.clj

@@ -54,23 +54,6 @@
         (spit path content)
         (tools.util/single-text-content (format "Successfully wrote to %s" path)))))
 
-(defn ^:private search-files [arguments {:keys [db]}]
-  (or (tools.util/invalid-arguments arguments (concat (path-validations db)
-                                                      [["pattern" #(not (string/blank? %)) "Invalid glob pattern '$pattern'"]]))
-      (let [pattern (get arguments "pattern")
-            pattern (if (string/includes? pattern "*")
-                      pattern
-                      (format "**%s**" pattern))
-            paths (reduce
-                   (fn [paths {:keys [uri]}]
-                     (concat paths (fs/glob (shared/uri->filename uri)
-                                            pattern)))
-                   []
-                   (:workspace-folders db))]
-        (if (seq paths)
-          (tools.util/single-text-content (string/join "\n" paths))
-          (tools.util/single-text-content "No matches found" :error)))))
-
 (defn ^:private run-ripgrep [path pattern include]
   (let [cmd (cond-> ["rg" "--files-with-matches" "--no-heading"]
               include (concat ["--glob" include])
@@ -264,20 +247,6 @@
                                               :description "The new absolute file path to move to."}}
                   :required ["source" "destination"]}
     :handler #'move-file}
-   "eca_search_files"
-   {:description (str "Recursively search for files and directories matching a pattern. "
-                      "Searches through all subdirectories from the starting path. The search "
-                      "is case-insensitive and matches partial names following java's FileSystem#getPathMatcher. Returns full paths to all "
-                      "matching items. Great for finding files when you don't know their exact location. "
-                      "**Only works within the directories: $workspaceRoots.**")
-    :parameters {:type "object"
-                 :properties {"path" {:type "string"
-                                      :description "The absolute path to start searching files from there."}
-                              "pattern" {:type "string"
-                                         :description (str "Glob pattern following java FileSystem#getPathMatcher matching files or directory names."
-                                                           "Use '**' to match search in multiple levels like '**.txt'")}}
-                 :required ["path" "pattern"]}
-    :handler #'search-files}
    "eca_grep"
    {:description (str "Fast content search tool that works with any codebase size. "
                       "Finds the paths to files that have matching contents using regular expressions. "

test/eca/features/tools/filesystem_test.clj

@@ -126,57 +126,6 @@
             {"path" (h/file-path "/foo/qux/new_file.clj")}
             {:db {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "bar"}]}}))))))
 
-(deftest search-files-test
-  (testing "invalid pattern"
-    (is (match?
-         {:error true
-          :contents [{:type :text
-                      :text "Invalid glob pattern ' '"}]}
-         (with-redefs [fs/exists? (constantly true)]
-           ((get-in f.tools.filesystem/definitions ["eca_search_files" :handler])
-            {"path" (h/file-path "/project/foo")
-             "pattern" " "}
-            {:db {:workspace-folders [{:uri (h/file-uri "file:///project/foo") :name "foo"}]}})))))
-  (testing "no matches"
-    (is (match?
-         {:error true
-          :contents [{:type :text
-                      :text "No matches found"}]}
-         (with-redefs [fs/exists? (constantly true)
-                       fs/glob (constantly [])]
-           ((get-in f.tools.filesystem/definitions ["eca_search_files" :handler])
-            {"path" (h/file-path "/project/foo")
-             "pattern" "foo"}
-            {:db {:workspace-folders [{:uri (h/file-uri "file:///project/foo") :name "foo"}]}})))))
-  (testing "matches with wildcard"
-    (is (match?
-         {:error false
-          :contents [{:type :text
-                      :text (str (h/file-path "/project/foo/bar/baz.txt") "\n"
-                                 (h/file-path "/project/foo/qux.txt") "\n"
-                                 (h/file-path "/project/foo/qux.clj"))}]}
-         (with-redefs [fs/exists? (constantly true)
-                       fs/glob (constantly [(fs/path (h/file-path "/project/foo/bar/baz.txt"))
-                                            (fs/path (h/file-path "/project/foo/qux.txt"))
-                                            (fs/path (h/file-path "/project/foo/qux.clj"))])]
-           ((get-in f.tools.filesystem/definitions ["eca_search_files" :handler])
-            {"path" (h/file-path "/project/foo")
-             "pattern" "**"}
-            {:db {:workspace-folders [{:uri (h/file-uri "file:///project/foo") :name "foo"}]}})))))
-  (testing "matches without wildcard"
-    (is (match?
-         {:error false
-          :contents [{:type :text
-                      :text (str (h/file-path "/project/foo/bar/baz.txt") "\n"
-                                 (h/file-path "/project/foo/qux.txt"))}]}
-         (with-redefs [fs/exists? (constantly true)
-                       fs/glob (constantly [(fs/path (h/file-path "/project/foo/bar/baz.txt"))
-                                            (fs/path (h/file-path "/project/foo/qux.txt"))])]
-           ((get-in f.tools.filesystem/definitions ["eca_search_files" :handler])
-            {"path" (h/file-path "/project/foo")
-             "pattern" ".txt"}
-            {:db {:workspace-folders [{:uri (h/file-uri "file:///project/foo") :name "foo"}]}}))))))
-
 (deftest grep-test
   (testing "invalid pattern"
     (is (match?