chore(sdk): sdk now stores shared deps (#108)

* sdk package

* Update Blocks.ts

* ci

* lint

* fix eslint sdk

* fix lint

* Update core.yml

* Revert "Update core.yml"

This reverts commit 09d9f31.

* Update tsconfig.json

* Update package.json

* Update eslint.config.mjs

* Update ToolsManager.ts

Author: neSpecc

.github/workflows/core.yml

@@ -0,0 +1,22 @@
+name: Core check
+on:
+  pull_request:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run ESLint check
+        uses: ./.github/actions/lint
+        with:
+          package-name: '@editorjs/core'
+
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Build the package
+        uses: ./.github/actions/build
+        with:
+          package-name: '@editorjs/core'

.github/workflows/sdk.yml

@@ -0,0 +1,22 @@
+name: SDK check
+on:
+  pull_request:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run ESLint check
+        uses: ./.github/actions/lint
+        with:
+          package-name: '@editorjs/sdk'
+
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Build the package
+        uses: ./.github/actions/build
+        with:
+          package-name: '@editorjs/sdk'

packages/core/eslint.config.mjs

@@ -21,6 +21,14 @@ export default [
         ],
         ignoreTypeImport: true,
       }],
+      // @todo: remove when we setup eslint to correctly handle the types
+      'n/no-missing-import': 'off',
+      '@typescript-eslint/no-unsafe-call': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-unsafe-argument': 'off',
+      '@typescript-eslint/no-missing-import': 'off',
+      '@typescript-eslint/no-unsafe-return': 'off',
     },
   },
 ];

packages/core/package.json

@@ -8,7 +8,7 @@
     "build": "yarn clear && tsc --build tsconfig.build.json",
     "dev": "yarn build --watch",
     "lint": "eslint ./src",
-    "lint:ci": "yarn lint --max-warnings 0",
+    "lint:ci": "eslint --config ./eslint.config.mjs ./src --max-warnings 0",
     "lint:fix": "yarn lint --fix",
     "clear": "rm -rf ./dist && rm -rf ./tsconfig.build.tsbuildinfo"
   },

packages/core/src/api/BlocksAPI.ts

@@ -2,14 +2,15 @@ import 'reflect-metadata';
 import { Inject, Service } from 'typedi';
 import { BlocksManager } from '../components/BlockManager.js';
 import { BlockToolData, ToolConfig } from '@editorjs/editorjs';
-import { CoreConfigValidated } from '../entities/index.js';
+import { CoreConfigValidated } from '@editorjs/sdk';
+import { BlocksAPI as BlocksApiInterface } from '@editorjs/sdk';
 
 /**
  * Blocks API
  *  - provides methods to work with blocks
  */
 @Service()
-export class BlocksAPI {
+export class BlocksAPI implements BlocksApiInterface {
   /**
    * BlocksManager instance to work with blocks
    */
@@ -58,7 +59,6 @@ export class BlocksAPI {
   ): void {
     this.#blocksManager.insert({
       type,
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       data,
       index,
       replace,

packages/core/src/api/SelectionAPI.ts

@@ -4,13 +4,14 @@ import { Service } from 'typedi';
 import { SelectionManager } from '../components/SelectionManager.js';
 import { createInlineToolName } from '@editorjs/model';
 import { InlineToolFormatData } from '@editorjs/sdk';
+import { SelectionAPI as SelectionApiInterface } from '@editorjs/sdk';
 
 /**
  * Selection API class
  * - provides methods to work with selection
  */
 @Service()
-export class SelectionAPI {
+export class SelectionAPI implements SelectionApiInterface {
   #selectionManager: SelectionManager;
 
   /**

packages/core/src/api/index.ts

@@ -1,13 +1,14 @@
 import 'reflect-metadata';
 import { Inject, Service } from 'typedi';
+import { EditorAPI as EditorApiInterface } from '@editorjs/sdk';
 import { BlocksAPI } from './BlocksAPI.js';
 import { SelectionAPI } from './SelectionAPI.js';
 
 /**
  * Class gathers all Editor's APIs
  */
 @Service()
-export class EditorAPI {
+export class EditorAPI implements EditorApiInterface {
   /**
    * Blocks API instance to work with blocks
    */

packages/core/src/components/BlockManager.ts

@@ -4,9 +4,7 @@ import { Inject, Service } from 'typedi';
 import { BlockToolAdapter, CaretAdapter, FormattingAdapter } from '@editorjs/dom-adapters';
 import ToolsManager from '../tools/ToolsManager.js';
 import { BlockAPI, BlockToolData } from '@editorjs/editorjs';
-import { CoreConfigValidated } from '../entities/Config.js';
-import { BlockAddedCoreEvent, BlockRemovedCoreEvent } from './EventBus/index.js';
-import { EventBus } from '@editorjs/sdk';
+import { CoreConfigValidated, EventBus, BlockAddedCoreEvent, BlockRemovedCoreEvent } from '@editorjs/sdk';
 /**
  * Parameters for the BlocksManager.insert() method
  */
@@ -121,7 +119,6 @@ export class BlocksManager {
       newIndex = this.#model.length + (replace ? 0 : 1);
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     this.#model.addBlock(this.#config.userId, {
       ...data,
       name: type,