cm3588nas - Adding support for custom SPI NOR flash

[vivivitus]

I would like to use a SPI flash and run your UEFI on it. My goal is to then boot from USB, eMMC, etc. I have soldered a SPI NOR flash (W25Q128JVSIQ) onto the cm3588 board, which, as far as I can see, is not supported. Now I'm wondering what I need to do to get this chip supported.
Maybe someone can help me with this or suggest a chip that works out of the box.

The log looks like this:

DDR 9fa84341ce typ 24/09/06-09:51:11,fwver: v1.18
ch0 ttot6
ch1 ttot6
ch2 ttot6
ch3 ttot6
ch0 ttot7
LPDDR5, 2400MHz
channel[0] BW=16 Col=10 Bk=16 CS0 Row=16 CS1 Row=16 CS=2 Die BW=16 Size=4096MB
ch1 ttot7
channel[1] BW=16 Col=10 Bk=16 CS0 Row=16 CS1 Row=16 CS=2 Die BW=16 Size=4096MB
ch2 ttot7
channel[2] BW=16 Col=10 Bk=16 CS0 Row=16 CS1 Row=16 CS=2 Die BW=16 Size=4096MB
ch3 ttot7
channel[3] BW=16 Col=10 Bk=16 CS0 Row=16 CS1 Row=16 CS=2 Die BW=16 Size=4096MB
Manufacturer ID:0xff
DQS rds:l0,h1 
CH0 RX Vref:26.3%, TX Vref:21.0%,22.0%
DQ rds:l1 h1 l0 h1 l0 h3 h2 l0, l1 h7 h1 h1 l0 l0 h1 l0 

DQS rds:l0,h1 
CH1 RX Vref:27.1%, TX Vref:18.0%,18.0%
DQ rds:h1 l1 h1 h2 h2 l0 l0 l0, h2 l1 l1 h1 l1 h7 l1 h5 

DQS rds:l0,l0 
CH2 RX Vref:28.9%, TX Vref:20.0%,21.0%
DQ rds:h4 h1 h2 h6 h2 h1 l0 h5, h4 h1 h5 h1 h4 h1 h1 h2 

DQS rds:l0,h1 
CH3 RX Vref:27.9%, TX Vref:20.0%,19.0%
DQ rds:h1 l0 l0 h1 h2 h7 l0 h1, h1 h4 l0 h3 h3 h4 h1 h2 

stride=0x2, ddr_config=0x6
hash ch_mask0-1 0x20 0x40, bank_mask0-3 0x0 0x2400 0x44800 0x89000, rank_mask0 0x2000
change to F1: 534MHz
ch0 ttot6
ch1 ttot6
ch2 ttot6
ch3 ttot6
change to F2: 1320MHz
ch0 ttot8
ch1 ttot8
ch2 ttot8
ch3 ttot8
change to F3: 1968MHz
ch0 ttot6
ch1 ttot6
ch2 ttot6
ch3 ttot6
change to F0: 2400MHz
ch0 ttot7
ch1 ttot7
ch2 ttot7
ch3 ttot7
out
U-Boot SPL board init
U-Boot SPL 2017.09-g5f53abfa1e-221223 #zzz (Dec 26 2022 - 09:10:09)
unrecognized JEDEC id bytes: ef, 80, 18
Trying to boot from MMC2
MMC: no card present
mmc_init: -123, time 0
spl: mmc init failed with error: -123
Trying to boot from MMC1
Card did not respond to voltage select!
mmc_init: -95, time 14
spl: mmc init failed with error: -95
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###
# Reset the board to bootrom #

The following line is particularly noteworthy:
unrecognized JEDEC id bytes: ef, 80, 18

[Tnze]

The SPL is basically a U-boot which is loaded to SRAM by BootROM. So I think if you want to support a new SPI Nor Flash, you should add driver to U-boot and build a new SPL. Then re-pack it into a idbloader.img

[Tnze]

Your SPI NOR Flash is supported by latest U-Boot.

At u-boot-2026.01.tar.bz\u-boot-2026.01\drivers\mtd\spi\spi-nor-ids.c:

	{
		INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,
			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
	}

Try port this to rockchip's u-boot:

git clone https://github.com/rockchip-linux/u-boot.git
cd u-boot

vim drivers/mtd/spi/spi-nor-ids.c

make clean
./make.sh CROSS_COMPILE=aarch64-linux-gnu- rk3588
./make.sh --spl
cp spl/u-boot-spl.bin ~/edk2-rk3588/misc/rk3588_spl_v1.12.bin

[Tnze]

I just successfully add support for the SPI Nor Flash on my board

[vivivitus]

Sorry for the delay. thank you very much for looking into this, I will follow your instructions to add support for the IC.