Skip to content

Commit e5253fe

Browse files
committed
fix: kebab case pod name on kubectl run
1 parent 13b0e82 commit e5253fe

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/lib/configurations/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import exitHook from 'exit-hook'
2-
import { omit } from 'lodash'
2+
import { omit, kebabCase } from 'lodash'
33
import {
44
deletePod,
55
portForward,
@@ -40,7 +40,7 @@ export const deleteConfiguration = (configuratioName: string): void => {
4040

4141
export const execConfiguration = (configuration: Configuration) => {
4242
const pod = {
43-
name: `sql-proxy-${configuration.configurationName}-${randomString()}`,
43+
name: `sql-proxy-${kebabCase(configuration.configurationName)}-${randomString()}`,
4444
context: configuration.kubernetesContext,
4545
namespace: configuration.kubernetesNamespace,
4646
serviceAccount: configuration.kubernetesServiceAccount,

src/lib/updates.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export const notifyForUpdates = () => {
1515
updateCheckInterval: oneDayMs,
1616
})
1717

18-
if (update) {
18+
if (update && update.current !== update.latest) {
1919
const text =
2020
`${yellow(update.current)}${green(update.latest)}\n\n` +
2121
`${blue('brew')} upgrade ${name}\n` +

0 commit comments

Comments
 (0)