fix: strictNullChecks on bookmark.name which can be undefined

Author: danielweck

src/common/redux/states/bookmark.ts

@@ -13,7 +13,7 @@ export type TBookmarkState = TPQueueState<number, IBookmarkState>;
 
 export interface IBookmarkState {
     uuid: string;
-    name: string;
+    name: string | undefined;
     index: number;
 
     locatorExtended: MiniLocatorExtended,

src/renderer/reader/components/BookmarkEdit.tsx

@@ -19,11 +19,11 @@ import { BookmarkLocatorInfo } from "./BookmarkLocatorInfo";
 import { MiniLocatorExtended } from "readium-desktop/common/redux/states/locatorInitialState";
 
 interface IProps {
-    toggleBookmark: (name?: string) => void,
+    toggleBookmark: (name: string) => void,
     cancel?: () => void;
     uuid?: string;
     dockedMode?: boolean;
-    name: string;
+    name: string | undefined;
     locatorExtended: MiniLocatorExtended;
 }
 

src/renderer/reader/redux/sagas/note.ts

@@ -186,10 +186,10 @@ function* bookmarkPush(action: readerActions.bookmark.push.TAction) {
                             cfi: undefined,
                         },
                         cleanBefore: bookmark.locatorExtended.locator.locations.caretInfo?.cleanBefore || bookmark.locatorExtended.locator.text?.before || "",
-                        cleanText: bookmark.locatorExtended.locator.locations.caretInfo?.cleanText || bookmark.locatorExtended.locator.text?.highlight || bookmark.locatorExtended.locator.title || bookmark.name,
+                        cleanText: bookmark.locatorExtended.locator.locations.caretInfo?.cleanText || bookmark.locatorExtended.locator.text?.highlight || bookmark.locatorExtended.locator.title || bookmark.name || "",
                         cleanAfter: bookmark.locatorExtended.locator.locations.caretInfo?.cleanAfter || bookmark.locatorExtended.locator.text?.after || "",
                         rawBefore: bookmark.locatorExtended.locator.locations.caretInfo?.rawBefore || bookmark.locatorExtended.locator.text?.beforeRaw || "",
-                        rawText: bookmark.locatorExtended.locator.locations.caretInfo?.rawText || bookmark.locatorExtended.locator.text?.highlightRaw || bookmark.locatorExtended.locator.title || bookmark.name,
+                        rawText: bookmark.locatorExtended.locator.locations.caretInfo?.rawText || bookmark.locatorExtended.locator.text?.highlightRaw || bookmark.locatorExtended.locator.title || bookmark.name || "",
                         rawAfter: bookmark.locatorExtended.locator.locations.caretInfo?.rawAfter || bookmark.locatorExtended.locator.text?.afterRaw || "",
                     },
                     color: {red:  52, green: 152, blue: 219},
@@ -474,10 +474,10 @@ function* readerStart() {
                                 cfi: undefined,
                             },
                             cleanBefore: bookmark.locatorExtended.locator.locations.caretInfo?.cleanBefore || bookmark.locatorExtended.locator.text?.before || "",
-                            cleanText: bookmark.locatorExtended.locator.locations.caretInfo?.cleanText || bookmark.locatorExtended.locator.text?.highlight || bookmark.locatorExtended.locator.title || bookmark.name,
+                            cleanText: bookmark.locatorExtended.locator.locations.caretInfo?.cleanText || bookmark.locatorExtended.locator.text?.highlight || bookmark.locatorExtended.locator.title || bookmark.name || "",
                             cleanAfter: bookmark.locatorExtended.locator.locations.caretInfo?.cleanAfter || bookmark.locatorExtended.locator.text?.after || "",
                             rawBefore: bookmark.locatorExtended.locator.locations.caretInfo?.rawBefore || bookmark.locatorExtended.locator.text?.beforeRaw || "",
-                            rawText: bookmark.locatorExtended.locator.locations.caretInfo?.rawText || bookmark.locatorExtended.locator.text?.highlightRaw || bookmark.locatorExtended.locator.title || bookmark.name,
+                            rawText: bookmark.locatorExtended.locator.locations.caretInfo?.rawText || bookmark.locatorExtended.locator.text?.highlightRaw || bookmark.locatorExtended.locator.title || bookmark.name || "",
                             rawAfter: bookmark.locatorExtended.locator.locations.caretInfo?.rawAfter || bookmark.locatorExtended.locator.text?.afterRaw || "",
                         },
                         color: {red:  52, green: 152, blue: 219},