refactor: don't change username in comment service by default in base class

Author: mariajgrimaldi

eox_core/api/support/v1/views.py

@@ -115,9 +115,7 @@ def get_serializer_class(self):
 
     def patch(self, request, *args, **kwargs):
         """
-        Updates an edxapp user's attribute and synchronizes with the forum.
-
-        For users with different signup sources, updates are not allowed.
+        Allows to safely update an Edxapp user's attribute.
         """
         query = self.get_user_query(request)
         user = get_edxapp_user(**query)
@@ -131,9 +129,6 @@ def patch(self, request, *args, **kwargs):
             data = serializer.validated_data
             data["user"] = user
 
-            # Update user in cs_comments_service forums
-            replace_username_cs_user(**data)
-
         admin_fields = getattr(settings, "ACCOUNT_VISIBILITY_CONFIGURATION", {}).get(
             "admin_fields", {}
         )
@@ -154,13 +149,13 @@ def get_serializer_class(self):
         """
         return WrittableEdxappUsernameSerializer
 
-    @audit_drf_api(action="Update an Edxapp user's Username.", method_name='eox_core_api_method')
+    @audit_drf_api(action="Update an Edxapp user's Username.", method_name="eox_core_api_method")
     def patch(self, request, *args, **kwargs):
         """
         Allows to safely update an Edxapp user's Username along with the
         forum associated User.
 
-        For now users that have different signup sources cannot be updated.
+        This method is overridden to include explicit forum synchronization.
 
         For example:
 
@@ -175,7 +170,28 @@ def patch(self, request, *args, **kwargs):
         **Response values**
             User serialized.
         """
-        return super().patch(request, *args, **kwargs)
+        query = self.get_user_query(request)
+        user = get_edxapp_user(**query)
+        data = request.data
+
+        with transaction.atomic():
+            serializer = self.get_serializer_class()(user, data=data)
+            serializer.is_valid(raise_exception=True)
+            serializer.save()
+
+            data = serializer.validated_data
+            data["user"] = user
+
+            # Update user in cs_comments_service forums
+            replace_username_cs_user(**data)
+
+        admin_fields = getattr(settings, "ACCOUNT_VISIBILITY_CONFIGURATION", {}).get(
+            "admin_fields", {}
+        )
+        serialized_user = EdxappUserReadOnlySerializer(
+            user, custom_fields=admin_fields, context={"request": request}
+        )
+        return Response(serialized_user.data)
 
 
 class EdxappReplaceEmail(EdxappUserUpdateBase):
@@ -187,18 +203,17 @@ def get_serializer_class(self):
         """Returns the serializer class to use."""
         return WrittableEdxappEmailSerializer
 
-    @audit_drf_api(action="Update an Edxapp user's Email.", method_name='eox_core_api_method')
+    @audit_drf_api(action="Update an Edxapp user's Email.", method_name="eox_core_api_method")
     def patch(self, request, *args, **kwargs):
         """
-        Allows to safely update an Edxapp user's Email along with the
-        forum associated User.
+        Allows to safely update an Edxapp user's Email address.
 
         For now users that have different signup sources cannot be updated.
 
         For example:
 
         **Requests**:
-            PATCH <domain>/eox-core/support-api/v1/replace-email/?email=old_email
+            PATCH <domain>/eox-core/support-api/v1/replace-email/?username=username
 
         **Request body**
             {