Skip to content

Commit 186d5d5

Browse files
authored
fix: Remove unreliable post-unmap SIGSEGV death tests (#128)
1 parent bcb6253 commit 186d5d5

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

.github/workflows/unit_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
matrix:
1919
image:
2020
- version: "12.2"
21-
# - version: "13.0" # disabled because of failing MemMap-related tests
21+
- version: "13.0"
2222
build:
2323
- type: "static"
2424
- type: "dynamic"

core/test/MemMapTest.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,5 @@ TEST(Memmap, AutoUnmap)
7171
testChar = str[1];
7272
EXPECT_EQ(testChar, 'A');
7373
}
74-
75-
// Accessing the file should now fail and the assignment shouldn't happen
76-
EXPECT_EXIT(testChar = str[2], ::testing::KilledBySignal(SIGSEGV), "");
77-
EXPECT_EQ(testChar, 'A');
7874
}
7975
#endif

core/test/TIFFIOTest.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -571,11 +571,6 @@ TEST(TIFFIO, WriteRead16UC1MMap)
571571

572572
// Cleanup the memory map
573573
UnmapFile(mmap_info);
574-
575-
// cv::Mat memory should be invalidated
576-
ElemT a{};
577-
EXPECT_EXIT(a = result.at<ElemT>(0, 0), ::testing::KilledBySignal(SIGSEGV), "");
578-
EXPECT_EQ(a, 0);
579574
}
580575

581576
TEST(TIFFIO, CannotWriteToMMap)

0 commit comments

Comments
 (0)