Added a script for for strict type checking (not required for CI). Updated the code to pass this script.

Author: eriq-augustine

.mypy.ini

@@ -0,0 +1,6 @@
+[mypy]
+
+exclude = _test\.py$
+
+strict = false
+disable_error_code = type-arg

pacai/agents/greedy.py

@@ -1,3 +1,5 @@
+import typing
+
 import pacai.core.action
 import pacai.core.agent
 import pacai.core.gamestate
@@ -42,7 +44,7 @@ class GreedyFeatureAgent(GreedyAgent):
     def __init__(self,
             feature_extractor_func: pacai.core.features.FeatureExtractor | pacai.util.reflection.Reference | str =
                     pacai.core.features.score_feature_extractor,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         self.weights: pacai.core.features.WeightDict = pacai.core.features.WeightDict()
@@ -55,7 +57,7 @@ def __init__(self,
     def evaluate_state(self,
             state: pacai.core.gamestate.GameState,
             action: pacai.core.action.Action | None = None,
-            **kwargs) -> float:
+            **kwargs: typing.Any) -> float:
         if (action is None):
             action = pacai.core.action.STOP
 

pacai/agents/mdp.py

@@ -22,7 +22,7 @@ def __init__(self,
             discount_rate: float = DEFAULT_DISCOUNT_RATE,
             exploration_rate: float = DEFAULT_EXPLORATION_RATE,
             mdp_state_class: typing.Type | pacai.util.reflection.Reference | str | None = pacai.core.mdp.MDPStateBoard,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         if (mdp_state_class is None):

pacai/agents/minimax.py

@@ -1,5 +1,6 @@
 import logging
 import math
+import typing
 
 import pacai.core.action
 import pacai.core.agent
@@ -21,7 +22,7 @@ def __init__(self,
             ply_count: int = DEFAULT_PLY_COUNT,
             alphabeta_prune: bool = False,
             expectimax: bool = False,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         # Parse (possibly string) arguments.
@@ -55,7 +56,7 @@ def __init__(self,
     def evaluate_state(self,
             state: pacai.core.gamestate.GameState,
             action: pacai.core.action.Action | None = None,
-            **kwargs) -> float:
+            **kwargs: typing.Any) -> float:
         self._stats_states_evaluated[-1] += 1
         return super().evaluate_state(state, action)
 

pacai/agents/scripted.py

@@ -1,3 +1,5 @@
+import typing
+
 import pacai.core.action
 import pacai.core.agent
 import pacai.core.gamestate
@@ -15,7 +17,7 @@ class ScriptedAgent(pacai.core.agent.Agent):
 
     def __init__(self,
             actions: list[pacai.core.action.Action] | list[str] | str | None = None,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         if (actions is None):

pacai/agents/searchproblem.py

@@ -1,4 +1,5 @@
 import logging
+import typing
 
 import edq.util.time
 
@@ -31,7 +32,7 @@ def __init__(self,
             problem_cost: pacai.core.search.CostFunction | pacai.util.reflection.Reference | str = DEFAULT_PROBLEM_COST,
             solver: pacai.core.search.SearchProblemSolver | pacai.util.reflection.Reference | str = DEFAULT_SOLVER,
             heuristic: pacai.core.search.SearchHeuristic | pacai.util.reflection.Reference | str = DEFAULT_HEURISTIC,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         claen_problem_class = pacai.util.reflection.resolve_and_fetch(type, problem)

pacai/agents/testing.py

@@ -1,4 +1,5 @@
 import time
+import typing
 
 import pacai.agents.dummy
 import pacai.core.action
@@ -17,7 +18,7 @@ def __init__(self,
             game_start_wait: float = 0.0,
             game_complete_wait: float = 0.0,
             get_action_wait: float = 0.0,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         self._game_start_wait: float = float(game_start_wait)

pacai/agents/userinput.py

@@ -1,3 +1,5 @@
+import typing
+
 import pacai.core.action
 import pacai.core.agent
 import pacai.core.agentaction
@@ -10,7 +12,7 @@ class UserInputAgent(pacai.core.agent.Agent):
 
     def __init__(self,
             remember_last_action: bool = True,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         super().__init__(**kwargs)
 
         self._remember_last_action: bool = remember_last_action

pacai/capture/agents.py

@@ -16,7 +16,7 @@ class DefensiveAgent(pacai.agents.greedy.GreedyFeatureAgent):
 
     def __init__(self,
             override_weights: dict[str, float] | None = None,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         kwargs['feature_extractor_func'] = _extract_baseline_defensive_features
         super().__init__(**kwargs)
 
@@ -46,7 +46,7 @@ class OffensiveAgent(pacai.agents.greedy.GreedyFeatureAgent):
 
     def __init__(self,
             override_weights: dict[str, float] | None = None,
-            **kwargs) -> None:
+            **kwargs: typing.Any) -> None:
         kwargs['feature_extractor_func'] = _extract_baseline_offensive_features
         super().__init__(**kwargs)
 
@@ -70,7 +70,7 @@ def _extract_baseline_defensive_features(
         state: pacai.core.gamestate.GameState,
         action: pacai.core.action.Action,
         agent: pacai.core.agent.Agent | None = None,
-        **kwargs) -> pacai.core.features.FeatureDict:
+        **kwargs: typing.Any) -> pacai.core.features.FeatureDict:
     agent = typing.cast(DefensiveAgent, agent)
     state = typing.cast(pacai.capture.gamestate.GameState, state)
 
@@ -108,7 +108,7 @@ def _extract_baseline_offensive_features(
         state: pacai.core.gamestate.GameState,
         action: pacai.core.action.Action,
         agent: pacai.core.agent.Agent | None = None,
-        **kwargs) -> pacai.core.features.FeatureDict:
+        **kwargs: typing.Any) -> pacai.core.features.FeatureDict:
     agent = typing.cast(OffensiveAgent, agent)
     state = typing.cast(pacai.capture.gamestate.GameState, state)
 

pacai/capture/bin.py

@@ -17,7 +17,7 @@
 
 RANDOM_BOARD_PREFIX: str = 'random'
 
-def set_cli_args(parser: argparse.ArgumentParser, **kwargs) -> argparse.ArgumentParser:
+def set_cli_args(parser: argparse.ArgumentParser, **kwargs: typing.Any) -> argparse.ArgumentParser:
     """
     Set Capture-specific CLI arguments.
     This is a sibling to init_from_args(), as the arguments set here can be interpreted there.
@@ -86,7 +86,7 @@ def get_additional_ui_options(args: argparse.Namespace) -> dict[str, typing.Any]
         'sprite_sheet_path': DEFAULT_SPRITE_SHEET,
     }
 
-def log_capture_results(results: list[pacai.core.game.GameResult], winning_agent_indexes: set[int], prefix = '') -> None:
+def log_capture_results(results: list[pacai.core.game.GameResult], winning_agent_indexes: set[int], prefix: str = '') -> None:
     """
     Log the result of running several games.
     """