Skip to content

Commit 54c18f6

Browse files
authored
Delete global.json (#228)
Removes the `global.json` file and configures the build workflow to directly use the .NET 9 SDK. This simplifies the build configuration and avoids potential issues related to the working directory when using the `dotnet` CLI.
1 parent 624823c commit 54c18f6

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

.github/workflows/build-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
- name: Setup .NET
4141
uses: actions/setup-dotnet@v4
4242
with:
43-
global-json-file: GitHubIssueFormsParser/global.json
43+
dotnet-version: '9.x'
4444
- name: Cache/Restore NuGets
4545
uses: actions/cache@v4
4646
with:

GitHubIssueFormsParser/global.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

docs/dev-notes/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,6 @@ github-issue-parser parse-issue-form `
101101

102102
- There is a set of NuGet packages that are only applied in test projects by using the condition `"'$(IsTestProject)' == 'true'"`. To make this work the `csproj` for the test projects must have the `<IsTestProject>true</IsTestProject>` property defined. Adding this property manually shouldn't be needed because it should be added by the `Microsoft.NET.Test.Sdk` package however there seems to be an issue with this when running tests outside of Visual Studio. See [this GitHub issue](https://github.com/dotnet/sdk/issues/3790#issuecomment-1100773198) for more info.
103103

104-
- When running `dotnet` CLI commands make sure you are at the `/GitHubIssueFormsParser` folder so that the `global.json` is respected. If you don't you might get unexpected results when building the solution. As explained in [global.json overview](https://learn.microsoft.com/en-us/dotnet/core/tools/global-json):
105-
106-
> The .NET SDK looks for a global.json file in the current working directory (which isn't necessarily the same as the project directory) or one of its parent directories.
107-
108104
## Deterministic Build configuration
109105

110106
Following the guide from [Deterministic Builds](https://github.com/clairernovotny/DeterministicBuilds) the `ContinuousIntegrationBuild` setting on the [Directory.Build.props](/GitHubIssueFormsParser/Directory.Build.props) is set to true, if the build is being executed in GitHub actions.

0 commit comments

Comments
 (0)