Skip to content

Commit 55fff86

Browse files
committed
and again
1 parent 2485714 commit 55fff86

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

.claude/settings.local.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@
9999
"Bash(sed -i 's/\\\\[\\\\[maybe_unused\\\\]\\\\] bool ok = dll_zone\\\\.set_subnet/[[maybe_unused]] auto ok = dll_zone.set_subnet/' /var/home/edward/projects/Canopy/tests/test_host/type_test_libcoro_ipc_dll_suite.cpp)",
100100
"Bash(sed -i 's/\\\\[\\\\[maybe_unused\\\\]\\\\] bool ok = child_zone\\\\.set_subnet/[[maybe_unused]] auto ok = child_zone.set_subnet/g' /var/home/edward/projects/Canopy/benchmarking/fullstack/src/benchmark_ipc.cpp)",
101101
"Bash(./build_debug/output/zone_address_test 2>&1)",
102-
"Bash(ldd /var/home/edward/projects/Canopy2/build_debug_coroutine/output/libcanopy_libcoro_spsc_example_dll.so)"
102+
"Bash(ldd /var/home/edward/projects/Canopy2/build_debug_coroutine/output/libcanopy_libcoro_spsc_example_dll.so)",
103+
"Bash(git -C /var/home/edward/projects/Canopy2 show HEAD:submodules/CMakeLists.txt)"
103104
]
104105
},
105106
"enabledPlugins": {}

cmake/Canopy.cmake

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -257,23 +257,16 @@ if(NOT DEPENDENCIES_LOADED)
257257
message(FATAL_ERROR "submodule init failed")
258258
endif()
259259

260-
# Clear any 'update = none' config that prevents submodule update from fetching
261-
foreach(submodule ${CANOPY_REQUIRED_SUBMODULES})
262-
execute_process(
263-
COMMAND ${GIT_EXECUTABLE} config --local --unset submodule.${submodule}.update
264-
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
265-
RESULT_VARIABLE GIT_UNSET_RESULT
266-
OUTPUT_QUIET ERROR_QUIET)
267-
endforeach()
268-
269-
# Update all required submodules except llama.cpp (handled separately with --depth 1)
260+
# Update all required submodules except llama.cpp (handled separately with --depth 1). --checkout explicitly
261+
# overrides any 'update = none' entry in .gitmodules so that optional submodules (googletest,
262+
# libcoro_for_enclaves, etc.) are actually fetched.
270263
set(CANOPY_STANDARD_SUBMODULES ${CANOPY_REQUIRED_SUBMODULES})
271264
list(REMOVE_ITEM CANOPY_STANDARD_SUBMODULES submodules/llama.cpp)
272265

273266
if(CANOPY_STANDARD_SUBMODULES)
274-
message(STATUS "Submodule update (force)")
267+
message(STATUS "Submodule update")
275268
execute_process(
276-
COMMAND ${GIT_EXECUTABLE} submodule update --init --force -- ${CANOPY_STANDARD_SUBMODULES}
269+
COMMAND ${GIT_EXECUTABLE} submodule update --init --checkout -- ${CANOPY_STANDARD_SUBMODULES}
277270
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
278271
RESULT_VARIABLE GIT_SUBMOD_RESULT)
279272

@@ -283,10 +276,11 @@ if(NOT DEPENDENCIES_LOADED)
283276
endif()
284277

285278
if(CANOPY_BUILD_DEMOS)
286-
# llama.cpp is a very large repository; use --depth 1 to avoid downloading the full history
279+
# llama.cpp is a very large repository; use --depth 1 to avoid downloading the full history. --checkout
280+
# overrides 'update = none' in .gitmodules.
287281
message(STATUS "Submodule update (shallow): submodules/llama.cpp")
288282
execute_process(
289-
COMMAND ${GIT_EXECUTABLE} submodule update --init --depth 1 -- submodules/llama.cpp
283+
COMMAND ${GIT_EXECUTABLE} submodule update --init --checkout --depth 1 -- submodules/llama.cpp
290284
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
291285
RESULT_VARIABLE GIT_LLAMA_RESULT)
292286

0 commit comments

Comments
 (0)