Fix pragma compilation errors in generator

edwardbr · claude · edwardbr · commit 93b0c7cca87a · 2026-01-22T20:58:58.000Z
Corrected pragma directives around args.hxx include in generator/src/main.cpp.
Changed from chained _Pragma directives to proper #pragma syntax, fixed warning
name from -Wno-gnu-zero-variadic-macro-arguments to -Wgnu-zero-variadic-macro-arguments,
and added GCC compiler support alongside Clang.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/cmake/Linux.cmake b/cmake/Linux.cmake
@@ -136,8 +136,7 @@ set(CANOPY_WARN_PEDANTIC
     -DCANOPY_WARN_PEDANTIC
     ${CANOPY_WARN_BASELINE}
     -Wpedantic # be pedantic
-    -Wsign-conversion # Warn on implicit sign conversions
-    -Wconversion # Warn on implicit type conversions
+    # -Wsign-conversion # Warn on implicit sign conversions -Wconversion # Warn on implicit type conversions
     -Wfloat-conversion # Warn on float conversions
     -Wdouble-promotion # Warn when float promoted to double
 )
diff --git a/demos/websocket/server/demo.cpp b/demos/websocket/server/demo.cpp
@@ -21,22 +21,22 @@ namespace websocket_demo
             return nullptr;
         }
 
-        CORO_TASK(int) add(double first_val, double second_val, double& response)
+        CORO_TASK(int) add(double first_val, double second_val, double& response) override
         {
             response = first_val + second_val;
             CO_RETURN rpc::error::OK();
         }
-        CORO_TASK(int) subtract(double first_val, double second_val, double& response)
+        CORO_TASK(int) subtract(double first_val, double second_val, double& response) override
         {
             response = first_val - second_val;
             CO_RETURN rpc::error::OK();
         }
-        CORO_TASK(int) multiply(double first_val, double second_val, double& response)
+        CORO_TASK(int) multiply(double first_val, double second_val, double& response) override
         {
             response = first_val * second_val;
             CO_RETURN rpc::error::OK();
         }
-        CORO_TASK(int) divide(double first_val, double second_val, double& response)
+        CORO_TASK(int) divide(double first_val, double second_val, double& response) override
         {
             response = first_val / second_val;
             CO_RETURN rpc::error::OK();
diff --git a/generator/src/main.cpp b/generator/src/main.cpp
@@ -9,8 +9,23 @@
 #include <filesystem>
 #include <fstream>
 
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
 
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #include "commonfuncs.h"
 #include "macro_parser.h"
 
diff --git a/submodules/yas b/submodules/yas
@@ -1 +1 @@
-Subproject commit 4b961be0a01856ccf00108094a871dad79b8f1d1
+Subproject commit 2f515a0948c15573c3ce16ba6c76f0024029b98d
diff --git a/tests/fuzz_test/fuzz_test_main.cpp b/tests/fuzz_test/fuzz_test_main.cpp
@@ -31,7 +31,23 @@
 #endif
 
 // Other headers
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #include <spdlog/spdlog.h>
 #include <yas/types/std/string.hpp>
 #include <yas/types/std/vector.hpp>
diff --git a/tests/test_host/hierachical_transport_tests.cpp b/tests/test_host/hierachical_transport_tests.cpp
@@ -20,7 +20,23 @@
 #endif
 
 // Other headers
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #ifdef CANOPY_BUILD_COROUTINE
 #include <coro/io_scheduler.hpp>
 #endif
diff --git a/tests/test_host/main.cpp b/tests/test_host/main.cpp
@@ -3,8 +3,23 @@
  *   All rights reserved.
  */
 
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
 
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
 
diff --git a/tests/test_host/post_functionality_test_suite.cpp b/tests/test_host/post_functionality_test_suite.cpp
@@ -21,7 +21,23 @@
 #endif
 
 // Other headers
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #ifdef CANOPY_BUILD_COROUTINE
 #include <coro/io_scheduler.hpp>
 #endif
diff --git a/tests/test_host/remote_type_test_suite.cpp b/tests/test_host/remote_type_test_suite.cpp
@@ -20,7 +20,23 @@
 #endif
 
 // Other headers
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #ifdef CANOPY_BUILD_COROUTINE
 #include <coro/io_scheduler.hpp>
 #endif
diff --git a/tests/test_host/type_test_local_suite.cpp b/tests/test_host/type_test_local_suite.cpp
@@ -20,7 +20,23 @@
 #endif
 
 // Other headers
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wsuggest-override"
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#endif
+
 #include <args.hxx>
+
+#ifdef __clang__
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 #ifdef CANOPY_BUILD_COROUTINE
 #include <coro/io_scheduler.hpp>
 #endif

Original file line number	Diff line number	Diff line change
`@@ -21,22 +21,22 @@ namespace websocket_demo`
`21`	`21`	`return nullptr;`
`22`	`22`	`}`
`23`	`23`
`24`		`- CORO_TASK(int) add(double first_val, double second_val, double& response)`
	`24`	`+ CORO_TASK(int) add(double first_val, double second_val, double& response) override`
`25`	`25`	`{`
`26`	`26`	`response = first_val + second_val;`
`27`	`27`	`CO_RETURN rpc::error::OK();`
`28`	`28`	`}`
`29`		`- CORO_TASK(int) subtract(double first_val, double second_val, double& response)`
	`29`	`+ CORO_TASK(int) subtract(double first_val, double second_val, double& response) override`
`30`	`30`	`{`
`31`	`31`	`response = first_val - second_val;`
`32`	`32`	`CO_RETURN rpc::error::OK();`
`33`	`33`	`}`
`34`		`- CORO_TASK(int) multiply(double first_val, double second_val, double& response)`
	`34`	`+ CORO_TASK(int) multiply(double first_val, double second_val, double& response) override`
`35`	`35`	`{`
`36`	`36`	`response = first_val * second_val;`
`37`	`37`	`CO_RETURN rpc::error::OK();`
`38`	`38`	`}`
`39`		`- CORO_TASK(int) divide(double first_val, double second_val, double& response)`
	`39`	`+ CORO_TASK(int) divide(double first_val, double second_val, double& response) override`
`40`	`40`	`{`
`41`	`41`	`response = first_val / second_val;`
`42`	`42`	`CO_RETURN rpc::error::OK();`