Skip to content

Commit c19b914

Browse files
author
Edward Xiao
committed
- removeAttribute('value') in <Textbox/>
1 parent f74ff30 commit c19b914

File tree

7 files changed

+13
-16
lines changed

7 files changed

+13
-16
lines changed

lib/components/Textbox.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ var component = function component(_ref) {
655655
}
656656

657657
$el.current.removeAttribute('value');
658-
}, [internalValue]);
658+
});
659659
useEffect(function () {
660660
if (asyncObj) {
661661
if (asyncObj.message) {

lib/react-inputs-validation.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/react-inputs-validation.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/react-inputs-validation.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/react-inputs-validation.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-inputs-validation",
3-
"version": "3.2.4",
3+
"version": "3.2.5",
44
"description": "React form input validation components",
55
"main": "index.js",
66
"repository": {

src/js/Inputs/Textbox.tsx

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -385,16 +385,13 @@ const component: React.FC<Props> = ({
385385
},
386386
[value],
387387
);
388-
useEffect(
389-
() => {
390-
/* istanbul ignore if because it won't happen */
391-
if ($el === null) {
392-
return;
393-
}
394-
$el.current.removeAttribute('value');
395-
},
396-
[internalValue],
397-
);
388+
useEffect(() => {
389+
/* istanbul ignore if because it won't happen */
390+
if ($el === null) {
391+
return;
392+
}
393+
$el.current.removeAttribute('value');
394+
});
398395
useEffect(
399396
() => {
400397
if (asyncObj) {

0 commit comments

Comments
 (0)