Before submitting a new issue
Bug summary
Before anything thanks for the awesome package!
Since discussions aren't enabled in this project i am creating an issue for this feature request
Right now the buttons labels of this package are hardcoded with no possible ways of customizing it this limits the reach of this great package in non english react native apps.
I am playing with a local clone of the package and trying come up and an API design that the community would agree on. My general idea is letting the consumer handle the translations rather than bloating this package with it and so far i came up with two options:
The first option:
Adding getButtonLabel to the props CoachmarkProvider and providing it with the context to use for the internal components such as ToolTip.
The second option:
Instead of passing a function we pass an object that will expose the actions
accessibilityLabels: {
next: (nextStep, total) => t('coachmark.next', { nextStep, total }) // i18next example,
}
I could take care of integrating this once we agree on something 😁
Library version
0.5.1
Environment info
Steps to reproduce
noop
Reproducible example repository
noop
Before submitting a new issue
Bug summary
Before anything thanks for the awesome package!
Since discussions aren't enabled in this project i am creating an issue for this feature request
Right now the buttons labels of this package are hardcoded with no possible ways of customizing it this limits the reach of this great package in non english react native apps.
I am playing with a local clone of the package and trying come up and an API design that the community would agree on. My general idea is letting the consumer handle the translations rather than bloating this package with it and so far i came up with two options:
The first option:
Adding
getButtonLabelto the propsCoachmarkProviderand providing it with the context to use for the internal components such as ToolTip.The second option:
Instead of passing a function we pass an object that will expose the actions
I could take care of integrating this once we agree on something 😁
Library version
0.5.1
Environment info
Steps to reproduce
noop
Reproducible example repository
noop