Skip to content

Commit 4fcedc5

Browse files
chore: resolve feedback
1 parent 5b139f5 commit 4fcedc5

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

check.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,12 @@ if should_check edx_notes_api; then
132132
"curl --fail -L http://localhost:18120/heartbeat"
133133
fi
134134

135+
if should_check designer; then
136+
echo "Checking designer health:"
137+
run_check designer_heartbeat designer \
138+
"curl --fail -L http://localhost:18808/health/"
139+
fi
140+
135141
if should_check credentials; then
136142
echo "Checking credentials heartbeat:"
137143
run_check credentials_heartbeat credentials \

docker-compose-host.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ services:
4949
volumes:
5050
- ${DEVSTACK_WORKSPACE}/portal-designer:/edx/app/designer
5151
- ${PWD}/py_configuration_files/portal_designer.py:/edx/app/designer/designer/settings/devstack.py
52-
- ${PWD}/py_configuration_files/registrar.py:/edx/app/registrar/registrar/registrar/settings/devstack.py
5352
registrar-worker:
5453
volumes:
5554
- ${DEVSTACK_WORKSPACE}/registrar:/edx/app/registrar

docker-compose.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -875,6 +875,7 @@ services:
875875
designer:
876876
image: edxops/designer-dev:latest
877877
container_name: edx.devstack.designer
878+
hostname: designer.devstack.edx
878879
volumes:
879880
- .:/edx/app/designer
880881
command: bash -c 'while true; do python /edx/app/designer/manage.py runserver 0.0.0.0:18808; sleep 2; done'
@@ -885,7 +886,7 @@ services:
885886
networks:
886887
default:
887888
aliases:
888-
- edx.devstack.xqueue
889+
- edx.devstack.designer
889890
stdin_open: true
890891
tty: true
891892
environment:

options.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ ALWAYS_CACHE_PROGRAMS ?= false
6161
# The current value was chosen such that it would not change the existing
6262
# Devstack behavior.
6363
DEFAULT_SERVICES ?= \
64-
credentials+discovery+ecommerce+edx_notes_api+forum+frontend-app-authn+frontend-app-gradebook+frontend-app-payment+frontend-app-publisher+frontend-app-learning+lms+cms+designer
64+
credentials+discovery+ecommerce+edx_notes_api+forum+frontend-app-authn+frontend-app-gradebook+frontend-app-payment+frontend-app-publisher+frontend-app-learning+lms+cms
6565

6666
# All edX services, whether or not they are run by default.
6767
# Separated by plus signs.
6868
# Separated by plus signs. Listed in alphabetical order for clarity.
6969
EDX_SERVICES ?= \
70-
analyticsapi+codejail+credentials+cms+cms-worker+cms_watcher+discovery+ecommerce+edx_notes_api+forum+frontend-app-account+frontend-app-learner-dashboard+frontend-app-learner-record+frontend-app-profile+frontend-app-authn+frontend-app-course-authoring+frontend-app-gradebook+frontend-app-ora-grading+frontend-app-learning+frontend-app-library-authoring+frontend-app-payment+frontend-app-program-console+frontend-app-publisher+insights+lms+lms-worker+lms_watcher+registrar+registrar-worker+xqueue+xqueue_consumer+enterprise-catalog+license-manager
70+
analyticsapi+codejail+credentials+cms+cms-worker+cms_watcher+discovery+ecommerce+edx_notes_api+forum+frontend-app-account+frontend-app-learner-dashboard+frontend-app-learner-record+frontend-app-profile+frontend-app-authn+frontend-app-course-authoring+frontend-app-gradebook+frontend-app-ora-grading+frontend-app-learning+frontend-app-library-authoring+frontend-app-payment+frontend-app-program-console+frontend-app-publisher+insights+lms+lms-worker+lms_watcher+registrar+registrar-worker+xqueue+xqueue_consumer+enterprise-catalog+license-manager+designer
7171

7272
# Services with database migrations.
7373
# Should be a subset of $(EDX_SERVICES).

0 commit comments

Comments
 (0)