Fix bug in Tests/ParmParse (AMReX-Codes#5324)

Author: WeiqunZhang

Src/Base/AMReX_ParmParse.H

@@ -1724,7 +1724,9 @@ public:
     //! duplicates, only the last one is printed.
     static void prettyPrintUsedInputs (std::ostream& os);
 
-    //! Add keys and values from a file to the end of the PP table.
+    //! Add keys and values from a file to the end of the PP table.  This
+    //! function must be called on all MPI processes because it contains a
+    //! call to MPI_Bcast.
     static void addfile (std::string const& filename);
 
     static bool QueryUnusedInputs ();

Tests/ParmParse/GNUmakefile

@@ -1,4 +1,4 @@
-AMREX_HOME ?= ../../amrex
+AMREX_HOME ?= ../..
 
 DEBUG	= TRUE
 

Tests/ParmParse/main.cpp

@@ -41,7 +41,7 @@ int main(int argc, char* argv[])
         std::vector<std::string> sa;
         std::vector<std::string> sb;
         pp.getarr("sa", sa);
-        pp.getarr("sa", sb);
+        pp.getarr("sb", sb);
         AMREX_ALWAYS_ASSERT(sa == sb && (sa == std::vector<std::string>{"abc","xyz","123"}));
 
         IntVect iv;
@@ -325,25 +325,28 @@ int main(int argc, char* argv[])
             AMREX_ALWAYS_ASSERT(s == sv[i]);
         }
     }
-    if (ParallelDescriptor::IOProcessor()) // print & addfile
+
+    // print & addfile
     {
-        {
-            ParmParse pp;
-            pp.add("string-for-testing-addfile", "string for testing addfile");
-            pp.add("string-for-testing-addfile", "string for testing addfile");
-            int n = pp.countname("string-for-testing-addfile");
-            AMREX_ALWAYS_ASSERT(n==2);
-        }
+        ParmParse pp;
+        pp.add("string-for-testing-addfile", "string for testing addfile");
+        pp.add("string-for-testing-addfile", "string for testing addfile");
+        int n = pp.countname("string-for-testing-addfile");
+        AMREX_ALWAYS_ASSERT(n==2);
+    }
+    if (ParallelDescriptor::IOProcessor()) {
         std::ofstream ofs("my-inputs");
         ParmParse::prettyPrintTable(ofs);
-        ofs.close();
+    }
+    {
         ParmParse::addfile("my-inputs");
         std::string s;
         ParmParse pp;
         pp.get("string-for-testing-addfile", s);
         int n = pp.countname("string-for-testing-addfile");
         AMREX_ALWAYS_ASSERT(n==3 && s == "string for testing addfile");
     }
+
     { // UNSET directive
         ParmParse pp;
         // "unset_me" is defined then immediately unset in the inputs file