@@ -39,11 +39,7 @@ Checks: >
3939 -modernize-macro-to-enum,
4040 -modernize-return-braced-init-list,
4141 -modernize-use-constraints,
42- -modernize-use-designated-initializers,
43- -modernize-use-integer-sign-comparison,
4442 -modernize-use-ranges,
45- -modernize-use-starts-ends-with,
46- -modernize-use-std-numbers,
4743 -modernize-use-trailing-return-type,
4844 performance-*,
4945 -performance-enum-size,
@@ -53,7 +49,6 @@ Checks: >
5349 readability-*,
5450 -readability-avoid-nested-conditional-operator,
5551 -readability-avoid-unconditional-preprocessor-if,
56- -readability-container-contains,
5752 -readability-else-after-return,
5853 -readability-function-cognitive-complexity,
5954 -readability-function-size,
@@ -63,6 +58,7 @@ Checks: >
6358 -readability-magic-numbers,
6459 -readability-math-missing-parentheses,
6560 -readability-named-parameter,
61+ -readability-qualified-auto,
6662 -readability-redundant-casting,
6763 -readability-redundant-member-init,
6864 -readability-static-accessed-through-instance,
@@ -78,11 +74,10 @@ HeaderFilterRegex: '([^n].....|[^o]....|[^l]...|[^i]..|[^n].|[^t])\.H$'
7874# Only available in clang-tidy >= 17
7975HeaderFileExtensions : ['', "H", 'h', 'hh', 'hpp', 'hxx']
8076
81- # We will try to modernize this after switching to C++20
82- # -modernize-use-constraints
83- # -modernize-use-designated-initializers
84- # -modernize-use-std-numbers
85- # -modernize-use-ranges
86- # -modernize-use-integer-sign-comparison
87- # -modernize-use-starts-ends-with
88- # -readability-container-contains
77+ # modernize-use-constraints is not a required check:
78+ # C++20 concepts/constraints have too many compiler-specific issues
79+ # (MSVC, NVHPC, CUDA-on-Windows, etc.) to be used in AMReX.
80+
81+ # modernize-use-ranges is not a required check:
82+ # (1) Clang <= 15 has bugs with std::ranges.
83+ # (2) std::ranges::sort requires std::sortable, which is stricter than operator<.
0 commit comments