Commit e35a74a
authored
fix cargo-pgrx and pgrx-tests on Windows (pgcentralfoundation#1934)
Notes:
1. postgres must run without administrator privileges, so switch calling
`postgres` directly to starting postgres by `pg_ctl` in testing
2. Add Windows CI
3. known issue: `pgrx-cshim.c` is compiled with `-flto`, because,
without this flag, `pgrx_embed.exe` is linked to `postgres.exe`
4. known issue: `cargo-pgrx` downloads, instead of building, postgres
binaries from EDB website
5. known issue: `cargo pgrx run` and `cargo pgrx test` always print logs
for `pg_ctl start` on Windows (pipes generated by
`std::process::Command` are leaked to postgres, a command with
`Stdio::piped()` hangs, so we use `Stdio::inherit()` on Windows)
6. breaking change: this pull request fixes `PgLwLock` and `PgAtomic`
but introduces a breaking change about `PgLwLock` and `PgAtomic`: name
must be provided at `PgLwLock/PgAtomic::new`, `PgLwLock::from_named` is
removed and a parameter of `PgLwLock::attach` changes
7. breaking change: this pull request makes everything `C-unwind` and
it's necessary for downstream to switch from `C` to `C-unwind`
8. regression: `cargo-pgrx` users need to execute `sudo sysctl
fs.protected_fifos=0` before using `--runas` on Linux1 parent a4708eb commit e35a74a
File tree
51 files changed
+1380
-505
lines changed- .cargo
- .github/workflows
- cargo-pgrx
- src
- command
- templates
- pgrx-bindgen
- src
- pgrx-examples
- bad_ideas/src
- bgworker/src
- shmem/src
- wal_decoder/src
- pgrx-macros/src
- pgrx-pg-config/src
- pgrx-pg-sys/src
- submodules
- pgrx-sql-entity-graph/src
- pgrx-tests
- src
- framework
- tests
- pgrx/src
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
51 files changed
+1380
-505
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
579 | 579 | | |
580 | 580 | | |
581 | 581 | | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
0 commit comments