Backward compatibility

Author: MartinMystikJonas

phpstan.neon

@@ -162,6 +162,9 @@ parameters:
                 - '#^Call to an undefined method Latte\\Engine\:\:addExtension\(\)\.$#'
                 - '#^Parameter \#1 \$phpContent of method Efabrica\\PHPStanLatte\\Compiler\\Compiler\\Latte3Compiler::fixLines\(\) expects string, mixed given\.#'
                 - '#^PHPDoc tag @var with type array<string, callable> is not subtype of type array<string>\.#'
+                - '#^Parameter \#1 \$object of function get_class expects object, mixed given\.#'
+                - '#^Call to function is_array\(\) with array<Latte\\Extension> will always evaluate to true\.#'
+                - '#^Call to function is_object\(\) with Latte\\Extension will always evaluate to true\.#'
             path: src/Compiler/Compiler/Latte3Compiler.php
             reportUnmatched: false
 

src/Analyser/LatteContextAnalyser.php

@@ -235,7 +235,7 @@ private function saveLatteContextDataToCache(string $file, LatteContextData $fil
         }
         Filesystem::write(
             $cacheFile,
-            Json::encode($cacheData, true)
+            Json::encode($cacheData, JSON_PRETTY_PRINT)
         );
     }
 
@@ -247,8 +247,8 @@ private function loadLatteContextDataFromCache(string $file): ?LatteContextData
         }
 
         try {
-            $cacheData = Json::decode(Filesystem::read($cacheFile), true);
-        } catch (Exception) {
+            $cacheData = Json::decode(Filesystem::read($cacheFile), JSON_OBJECT_AS_ARRAY);
+        } catch (Exception $e) {
             FileSystem::delete($cacheFile);
             return null;
         }
@@ -299,7 +299,7 @@ private function loadLatteContextDataFromCache(string $file): ?LatteContextData
 
         try {
             return LatteContextData::fromJson($data, $this->typeStringResolver);
-        } catch (Exception) {
+        } catch (Exception $e) {
             FileSystem::delete($cacheFile);
             return null;
         }

src/Analyser/LatteContextData.php

@@ -127,7 +127,7 @@ public function jsonSerialize(): array
     /**
      * @param array{items: array{class: class-string<CollectedLatteContextObject>, data: mixed}[]} $data
      */
-    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static
+    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self
     {
         $collectedData = [];
         foreach ($data['items'] as $item) {

src/Compiler/Compiler/Latte3Compiler.php

@@ -31,12 +31,16 @@ public function __construct(
 
     public function getCacheKey(): string
     {
+        $extensions = $this->engine->getExtensions();
+        if (!is_array($extensions)) {
+            $extensions = [];
+        }
         return md5(
             implode('', array_keys($this->getFilters())) .
             implode('', array_keys($this->getFunctions())) .
             implode('', array_map(function ($extension) {
-                return get_class($extension);
-            }, $this->engine->getExtensions()))
+                return is_object($extension) ? get_class($extension) : null;
+            }, $extensions))
         );
     }
 

src/LatteContext/CollectedData/CollectedComponent.php

@@ -99,7 +99,7 @@ public function jsonSerialize(): array
     /**
      * @param array{class: string, className: string, methodName: string, component: array<string, mixed>, declared: bool} $data
      */
-    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static
+    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self
     {
 
         return new self(

src/LatteContext/CollectedData/CollectedError.php

@@ -64,7 +64,7 @@ public function jsonSerialize(): array
     /**
      * @param array{message: string, file: string, line?: int|null} $data
      */
-    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static
+    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self
     {
         return new self(
             $data['message'],

src/LatteContext/CollectedData/CollectedFilter.php

@@ -54,7 +54,7 @@ public function jsonSerialize(): array
     /**
      * @param array{className: string, methodName: string, filter: array<string, mixed>} $data
      */
-    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static
+    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self
     {
         return new self(
             $data['className'],

src/LatteContext/CollectedData/CollectedLatteContextObject.php

@@ -12,5 +12,5 @@ abstract class CollectedLatteContextObject implements JsonSerializable
     /**
      * @param array<mixed> $data
      */
-    abstract public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static;
+    abstract public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self;
 }

src/LatteContext/CollectedData/CollectedMethod.php

@@ -87,7 +87,7 @@ public function jsonSerialize(): array
     /**
      * @param array{className: string, methodName: string, alwaysTerminated?: bool, returnType?: string|null} $data
      */
-    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static
+    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self
     {
         return new self(
             $data['className'],

src/LatteContext/CollectedData/CollectedMethodCall.php

@@ -203,7 +203,7 @@ public function jsonSerialize(): array
     /**
      * @param array{callerClassName?: ?class-string, callerMethodName?: string, calledClassName?: ?class-string, calledMethodName?: string, isCalledConditionally?: bool, type?: string, params?: array<string, string|int|float|bool>, currentClassName?: ?class-string} $data
      */
-    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): static
+    public static function fromJson(array $data, TypeStringResolver $typeStringResolver): self
     {
         return new self(
             $data['callerClassName'] ?? null,