Make Collector return type more explicit #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not apply the fix to all collector classes in this repo - but I think you get the point and can do the rest on your own. if you have any questions left, feel free to ask. I am not a phpstan-latte user myself, therefore I did not take care of making this thing perfect. My primary motivation was to make sure people don't shoot their own feet because of problems with Collectors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while the previous return type was correct, it did not explicitly state/protect you from someone changing the collector and make it return a empty array.
thats a major problem which can happen, and I want to make sure this error will not bite you, like it did in my projects.
for in-detail context see phpstan/phpstan#11701 (comment)