Skip to content

Commit 033b2af

Browse files
tasks++
1 parent 432a72a commit 033b2af

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.tasks/active/TASK-147-cross-open-modification-interoperability.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,14 @@ Unify on the Rust/C trigger schema and semantics:
6565
- 2025-12-21: Task created from hard requirement: cross-open modification must work both directions.
6666
- 2025-12-21: First attempt by subagent failed — changed pks table schema AND trigger SQL but left backfill using old schema, causing "failed to backfill existing rows" error. Changes stashed and reverted.
6767
- 2025-12-21: **Remains in active** — needs more careful incremental approach.
68+
- 2025-12-21: **Phase 1 progress** (schema migration):
69+
- ✅ Fixed compound PK bug in getOrCreatePkKey (commit 255e316e) - dangling pointer fix
70+
- ✅ Refactored findPkFromBlob for new schema (commit 3b9a984d) - unpacks pk_blob, queries individual PK columns
71+
- ✅ Made getTableInfo public in as_crr.zig for reuse
72+
- ✅ Cross-open tests: 24/24 PASSING (direct table modifications work)
73+
- ❌ Sync operations: FAILING (need merge_insert.zig refactoring)
74+
- Created 7 triage tasks (TASK-149 through TASK-155) for remaining work
75+
- 2025-12-21: **Next**: Delegate TASK-149 (refactor insertIntoPksTableAndGetPk) to unblock sync INSERT path
6876

6977
## Implementation Notes (from failed attempt)
7078
The first approach tried to:

.tasks/triage/TASK-149-refactor-insertIntoPksTableAndGetPk.md renamed to .tasks/active/TASK-149-refactor-insertIntoPksTableAndGetPk.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Adapt `insertIntoPksTableAndGetPk` and related pks table insert functions to work with the new Rust/C-compatible schema where PK column values are stored directly instead of as a packed blob.
55

66
## Status
7-
- State: triage
7+
- State: active
88
- Priority: high (blocks sync operations)
99

1010
## Context
@@ -63,6 +63,7 @@ Triggering issue:
6363

6464
## Progress Log
6565
- 2025-12-21: Created from TASK-147 refactoring work. Compound PK bug fixed, findPkFromBlob refactored, this is next critical blocker.
66+
- 2025-12-21 14:30: Starting implementation. Reading existing code to understand the pattern from findPkFromBlob refactor.
6667

6768
## Completion Notes
6869
(Empty until done.)

0 commit comments

Comments
 (0)