Skip to content

Commit 1f453cc

Browse files
updated tasks
1 parent e780142 commit 1f453cc

File tree

2 files changed

+55
-5
lines changed

2 files changed

+55
-5
lines changed
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# TASK-118: Fix shell quoting in automigrate test script
2+
3+
## Status
4+
- [ ] Planned
5+
- [ ] Assigned
6+
- [ ] In Progress
7+
- [ ] Blocked (reason: ...)
8+
- [ ] Complete
9+
10+
## Priority
11+
high
12+
13+
## Assigned To
14+
(unassigned)
15+
16+
## Parent Docs / Cross-links
17+
- Triggering task: `.tasks/done/TASK-076-impl-automigrate.md`
18+
- Spec task: `.tasks/done/TASK-075-spec-automigrate.md`
19+
- Failing script: `zig/harness/test-automigrate.sh`
20+
- Delegate evidence: `.tasks/DELEGATE_WORK_HANDOFF.md` (Round 2025-12-20 (43))
21+
22+
## Description
23+
`crsql_automigrate` is implemented, but `zig/harness/test-automigrate.sh` reports `15/17` passing due to **shell escaping issues** (per TASK-076 completion notes and delegate evidence). This task fixes the test harness so the failing cases exercise the implementation correctly.
24+
25+
Constraints:
26+
- This is a **test-only** task.
27+
- Do not change `zig/src/automigrate.zig` or other implementation files.
28+
29+
## Files to Modify
30+
- `zig/harness/test-automigrate.sh`
31+
- (optional) `zig/harness/test-parity.sh` (only if it needs to report automigrate results consistently)
32+
33+
## Acceptance Criteria
34+
- [ ] `bash zig/harness/test-automigrate.sh` reports `17/17` pass
35+
- [ ] The fix is robust to schema strings containing single quotes and newlines
36+
- [ ] No changes to Zig implementation code
37+
38+
## Reproducible Command
39+
```bash
40+
cd /Users/tom/Developer/effect-native/cr-sqlite
41+
bash zig/harness/test-automigrate.sh
42+
```
43+
44+
## Progress Log
45+
### 2025-12-20
46+
- Filed from Round 43 evidence: 2 failures attributed to shell quoting.
47+
48+
## Completion Notes
49+
(append date + commit hash)

research/zig-cr/92-gap-backlog.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ Goal: invalidate the hypothesis that "Zig is done" by expanding cross-implementa
1616
- [x] **TASK-070** — Cover missing C suites: ext-data + sandbox ✓ `.tasks/done/TASK-070-zig-parity-extdata-sandbox.md`
1717
- ext-data: 15/15 tests pass (test-extdata.sh)
1818
- sandbox: 5/9 tests pass → TASK-117 filed for PK-only sentinel gap
19-
- [ ] **TASK-071** — Cover remaining C suites: crsqlite + is-crr `.tasks/backlog/TASK-071-zig-parity-crsqlite-is-crr.md`
20-
- [ ] **TASK-117** — Fix PK-only table sentinel emission `.tasks/backlog/TASK-117-zig-pk-only-sentinel-emission.md`
19+
- [x] **TASK-071** — Cover remaining C suites: crsqlite + is-crr `.tasks/done/TASK-071-zig-parity-crsqlite-is-crr.md`
20+
- [x] **TASK-117** — Fix PK-only table sentinel emission `.tasks/done/TASK-117-zig-pk-only-sentinel-emission.md`
2121

2222
### Build/Tooling Blockers
2323
- [x] **TASK-111** — Fix Zig 0.15 `SQLITE_TRANSIENT` alignment build error ✓ `.tasks/done/TASK-111-zig-build-sqlite-transient-alignment.md`
@@ -46,7 +46,8 @@ Goal: invalidate the hypothesis that "Zig is done" by expanding cross-implementa
4646
### Missing-feature RGRTDD tracks (spec then impl)
4747
- [x] **TASK-075** — Spec `crsql_automigrate` behavior ✓ `.tasks/done/TASK-075-spec-automigrate.md`
4848
- Test: `zig/harness/test-automigrate.sh` (17 tests, all RED until impl)
49-
- [ ] **TASK-076** — Implement `crsql_automigrate` in Zig → `.tasks/backlog/TASK-076-impl-automigrate.md` (tests in `zig/harness/test-automigrate.sh`)
49+
- [x] **TASK-076** — Implement `crsql_automigrate` in Zig ✓ `.tasks/done/TASK-076-impl-automigrate.md`
50+
- Status: `zig/harness/test-automigrate.sh` = 15/17 pass (2 test quoting failures)
5051
- [x] **TASK-077** — Spec `crsql_as_crr` backfill behavior ✓ `.tasks/done/TASK-077-spec-as-crr-backfill.md`
5152
- [x] **TASK-078** — Implement `crsql_as_crr` backfill in Zig ✓ `.tasks/done/TASK-078-impl-as-crr-backfill.md`
5253
- All 12 backfill tests pass
@@ -91,7 +92,7 @@ Goal: invalidate the hypothesis that "Zig is done" by expanding cross-implementa
9192

9293
| Rust Suite | Zig Coverage | Status |
9394
|------------|--------------|--------|
94-
| automigrate.rs | test-automigrate.sh | TASK-075 ✓ (spec), TASK-076 (impl blocked) |
95+
| automigrate.rs | test-automigrate.sh | TASK-075 ✓ (spec), TASK-076 (impl; 15/17 pass, test quoting follow-up) |
9596
| backfill.rs || TASK-096 + TASK-078 (all 12 tests pass) |
9697
| pack_columns.rs | MISSING | Blocked (TASK-081/082) |
9798
| pk_only_tables.rs | Partial | TASK-095 (test exists) |
@@ -110,7 +111,7 @@ Goal: invalidate the hypothesis that "Zig is done" by expanding cross-implementa
110111
| rs-fract.test.c | test-fract*.sh ||
111112
| is-crr.test.c | test-is-crr.sh ||
112113
| rows-impacted.test.c | test-parity.sh ||
113-
| sandbox.test.c | test-sandbox.sh | ⚠️ 5/9 (TASK-117 for PK-only sentinel) |
114+
| sandbox.test.c | test-sandbox.sh | (TASK-117 fixed; 9/9) |
114115
| changes-vtab.test.c | test-filters.sh ||
115116
| changes-vtab-rowid.test.c | test-rowid-slab.sh ||
116117
| crsqlite.test.c | test-e2e-sync.sh, test-alter.sh ||

0 commit comments

Comments
 (0)