Skip to content

Commit f7898ab

Browse files
++
1 parent d560ddd commit f7898ab

File tree

4 files changed

+40
-8
lines changed

4 files changed

+40
-8
lines changed

.wishes/blocked-on-tom/tom-review-crsql-mesh-instructions.md

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,22 @@ Context proposals:
2525
## Decisions (please answer each checkbox)
2626

2727
### A) Name alignment (reduces chaos)
28-
- [ ] **Package name**: pick one canonical name for the core engine: `@effect-native/crsql-mesh` vs `@effect-native/crsql-mesh-core` (some docs currently use both).
28+
- [x] **Package name**: pick one canonical name for the core engine: `@effect-native/crsql-mesh`
2929

3030
### B) Smallest “first ship” package set (reduces burden)
3131
Pick the smallest set of NEW packages we implement first (no bikeshedding, just pick):
32-
- [ ] Option 1 (smallest): protocol + transport interface + core engine
33-
- [ ] Option 2 (practical web-first): Option 1 + browser runtime adapter
34-
- [ ] Option 3 (practical node-first): Option 1 + node runtime adapter
32+
- [x] Option 3 (practical node-first): Option 1 + node runtime adapter
3533

3634
### C) Runtime split decisions (reduces control-freak knobs)
37-
- [ ] Bun: separate `@effect-native/crsql-mesh-runtime-bun` package, or fold into `...-runtime-node`
38-
- [ ] Electron: separate `...-runtime-electron`, or explicitly defer
35+
- Bun: separate `@effect-native/crsql-mesh-runtime-bun` package? fold into `...-runtime-node` with @effect/package-{node,but,browser} as possible; add a -bun specific package only if necessary
36+
- No Electron. I don't like Electron. I refuse to support it
3937

4038
### D) `@effect-native/crsql` boundary (reduces future betrayals)
4139
Where do the “db primitives” stop and “sync orchestration” start?
42-
- [ ] Confirm the split: `@effect-native/crsql` owns typed change rows + pull/apply helpers; mesh package owns version vectors + anti-entropy loop.
40+
- Confirm the split: `@effect-native/crsql` owns typed change rows + pull/apply helpers; mesh package owns version vectors + anti-entropy loop.
4341

4442
### E) Approval gate
45-
- [ ] Approved to proceed to **Phase 2 (requirements.md)** for the chosen packages under `effect-native/.specs/AGENTS.md`.
43+
- Approved to proceed to **Phase 2 (requirements.md)** for the chosen packages under `effect-native/.specs/AGENTS.md`.
4644

4745
## Notes
4846

@@ -55,3 +53,23 @@ Thing-golf bias:
5553

5654
- Move this file to `.wishes/done/` and add a short “Decisions” summary.
5755
- Then we’ll generate Phase 2 `requirements.md` for exactly the packages you approved.
56+
57+
58+
---
59+
60+
From Tom:
61+
62+
- updated effect-native/.specs/crsqlite-global-mesh-packages/instructions.md with
63+
- package names for new react-native packages
64+
65+
- effect-native/.specs/crsql-mesh/instructions.md approved
66+
67+
- TODO: Agent, update effect-native/.specs/crsql-mesh-protocol/instructions.md to reference the existing effect-native/packages-native/crsql/ that already includes a lot of stuff that makes serialization/de-serialization much simpler and cleaner. Pay particular attention to effect-native/packages-native/crsql/src/CrSqlSchema.ts and its effect-native/packages-native/crsql/test/
68+
69+
Product decision: rely on SQLite's unhex() (available in sqlite >= 3.50.2).
70+
If unhex() is missing or disabled in the host, we fail fast with UnhexUnavailable rather than adding feature-detection fallbacks.
71+
NOTE: verifying unhex() presence as early as possible in layer creation so that it'll be easier to know when there's a configuration issue
72+
73+
- TODO(Agent): add specs for react-native packages
74+
75+
- @effect-native/crsql-mesh-runtime-node should rely on @effect/platform
File renamed without changes.

.wishes/wasm-extras.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
our wasm build doesn't support loadable extensions
2+
so let's bake in a few extensions that I particularly like
3+
4+
- our new zig-based cr-sqlite (naturally)
5+
- https://github.com/asg017/sqlite-vec
6+
- full text search
7+
- BJSON

.zed/settings.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
// Folder-specific settings
2+
//
3+
// For a full list of overridable settings, and general information on folder-specific settings,
4+
// see the documentation: https://zed.dev/docs/configuring-zed#settings-files
5+
{
6+
"file_scan_exclusions": [".git","dist",".refs/bun/*/*",".refs/**/*.c"]
7+
}

0 commit comments

Comments
 (0)