You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .wishes/blocked-on-tom/tom-review-crsql-mesh-instructions.md
+26-8Lines changed: 26 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -25,24 +25,22 @@ Context proposals:
25
25
## Decisions (please answer each checkbox)
26
26
27
27
### A) Name alignment (reduces chaos)
28
-
-[]**Package name**: pick one canonical name for the core engine: `@effect-native/crsql-mesh` vs `@effect-native/crsql-mesh-core` (some docs currently use both).
28
+
-[x]**Package name**: pick one canonical name for the core engine: `@effect-native/crsql-mesh`
29
29
30
30
### B) Smallest “first ship” package set (reduces burden)
31
31
Pick the smallest set of NEW packages we implement first (no bikeshedding, just pick):
### C) Runtime split decisions (reduces control-freak knobs)
37
-
-[ ]Bun: separate `@effect-native/crsql-mesh-runtime-bun` package, or fold into `...-runtime-node`
38
-
-[ ]Electron: separate `...-runtime-electron`, or explicitly defer
35
+
- Bun: separate `@effect-native/crsql-mesh-runtime-bun` package? fold into `...-runtime-node` with @effect/package-{node,but,browser} as possible; add a -bun specific package only if necessary
36
+
-No Electron. I don't like Electron. I refuse to support it
- TODO: Agent, update effect-native/.specs/crsql-mesh-protocol/instructions.md to reference the existing effect-native/packages-native/crsql/ that already includes a lot of stuff that makes serialization/de-serialization much simpler and cleaner. Pay particular attention to effect-native/packages-native/crsql/src/CrSqlSchema.ts and its effect-native/packages-native/crsql/test/
68
+
69
+
Product decision: rely on SQLite's unhex() (available in sqlite >= 3.50.2).
70
+
If unhex() is missing or disabled in the host, we fail fast with UnhexUnavailable rather than adding feature-detection fallbacks.
71
+
NOTE: verifying unhex() presence as early as possible in layer creation so that it'll be easier to know when there's a configuration issue
72
+
73
+
- TODO(Agent): add specs for react-native packages
74
+
75
+
-@effect-native/crsql-mesh-runtime-node should rely on @effect/platform
0 commit comments