Fix update sync bug

Author: zerobias

packages/core/src/__tests__/keyval/edit.test.ts

@@ -1,5 +1,5 @@
 import { expect, test, describe } from 'vitest';
-import { createStore, combine } from 'effector';
+import { createStore, combine, createEvent, sample } from 'effector';
 import { keyval } from '@effector/model';
 
 function createEntities(fill?: Array<{ id: string }>) {
@@ -158,6 +158,43 @@ describe('edit.update', () => {
       { id: 'foo', count: 0, tag: 'x' },
     ]);
   });
+  test('sync stores after update', () => {
+    const entities = keyval(() => {
+      const $id = createStore('');
+      const $fieldA = createStore('');
+      const $count = createStore(0);
+      const inc = createEvent();
+      sample({
+        clock: inc,
+        source: $count,
+        fn: (n) => n + 1,
+        target: $count,
+      });
+      return {
+        key: 'id',
+        state: {
+          id: $id,
+          fieldA: $fieldA,
+          count: $count,
+        },
+        api: {
+          inc,
+        },
+        optional: ['count', 'fieldA'],
+      };
+    });
+    entities.edit.replaceAll([{ id: 'a' }, { id: 'b' }]);
+    entities.edit.update({ id: 'b', fieldA: 'x' });
+    expect(entities.$items.getState()).toEqual([
+      { id: 'a', fieldA: '', count: 0 },
+      { id: 'b', fieldA: 'x', count: 0 },
+    ]);
+    entities.api.inc({ key: 'b', data: undefined });
+    expect(entities.$items.getState()).toEqual([
+      { id: 'a', fieldA: '', count: 0 },
+      { id: 'b', fieldA: 'x', count: 1 },
+    ]);
+  });
 });
 
 describe('edit.replaceAll', () => {
@@ -246,4 +283,44 @@ describe('edit.map', () => {
       { id: 'bar', count: 0, tag: 'y' },
     ]);
   });
+  test('sync stores after update', () => {
+    const entities = keyval(() => {
+      const $id = createStore('');
+      const $fieldA = createStore('');
+      const $count = createStore(0);
+      const inc = createEvent();
+      sample({
+        clock: inc,
+        source: $count,
+        fn: (n) => n + 1,
+        target: $count,
+      });
+      return {
+        key: 'id',
+        state: {
+          id: $id,
+          fieldA: $fieldA,
+          count: $count,
+        },
+        api: {
+          inc,
+        },
+        optional: ['count', 'fieldA'],
+      };
+    });
+    entities.edit.replaceAll([{ id: 'a' }, { id: 'b' }]);
+    entities.edit.map({
+      keys: 'b',
+      map: () => ({ fieldA: 'x' }),
+    });
+    expect(entities.$items.getState()).toEqual([
+      { id: 'a', fieldA: '', count: 0 },
+      { id: 'b', fieldA: 'x', count: 0 },
+    ]);
+    entities.api.inc({ key: 'b', data: undefined });
+    expect(entities.$items.getState()).toEqual([
+      { id: 'a', fieldA: '', count: 0 },
+      { id: 'b', fieldA: 'x', count: 1 },
+    ]);
+  });
 });

packages/core/src/keyval.ts

@@ -318,6 +318,19 @@ export function keyval<Input, ModelEnhance, Api, Shape>(
       ...inputUpdate,
     };
     freshState.items[idx] = newItem;
+    const instance = freshState.instances[idx];
+    const storesToUpdate = [] as any[];
+    const updates = [] as any[];
+    for (const key in inputUpdate) {
+      const store = instance.props[key as any as keyof ModelEnhance];
+      storesToUpdate.push(store);
+      updates.push(inputUpdate[key]);
+    }
+    launch({
+      target: storesToUpdate,
+      params: updates,
+      defer: true,
+    });
   }
 
   const addFx = attach({

packages/core/vite.config.mts

@@ -2,6 +2,9 @@ import { defineConfig } from 'vitest/config';
 import tsconfigPaths from 'vite-tsconfig-paths';
 
 export default defineConfig({
-  test: { typecheck: { ignoreSourceErrors: true } },
+  test: {
+    reporters: 'default',
+    typecheck: { ignoreSourceErrors: true },
+  },
   plugins: [tsconfigPaths()],
 });