Skip to content

Commit 063c3c9

Browse files
authored
Prevent stack overflows by using larger stacks (#853)
Closes #847. Error occurred in #828, #841, #851, #852. Unfortunately I don't think we can set the stack size in `build.sbt` unless we use a forked JVM, so we have to set it manually using an argument to SBT (or an environment variable). The problem mainly comes from our abundant use of non-tail recursion, we could refactor this in the future. We should also decide on a specific stack size, I've set it to 1G for now which is quite large.
1 parent d57b530 commit 063c3c9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
node-version: ${{ env.NODE_VERSION }}
8989

9090
- name: Run tests
91-
run: EFFEKT_VALGRIND=1 EFFEKT_DEBUG=1 sbt clean test
91+
run: EFFEKT_VALGRIND=1 EFFEKT_DEBUG=1 sbt -J-Xss1G clean test
9292

9393
- name: Assemble fully optimized js file
9494
run: sbt effektJS/fullOptJS

0 commit comments

Comments
 (0)