Prevent jump out of boxed function in JS (#882)

marvinborner · jiribenes · web-flow · commit 4ec1a866a0ae · 2025-03-12T22:44:34.000+01:00
Closes #881 Solution proposed by @jiribenes, seems to solve the issue! Co-authored-by: Jiří Beneš <mail@jiribenes.com>
diff --git a/effekt/shared/src/main/scala/effekt/generator/js/TransformerCps.scala b/effekt/shared/src/main/scala/effekt/generator/js/TransformerCps.scala
@@ -200,7 +200,7 @@ object TransformerCps extends Transformer {
     case DirectApp(id, vargs, bargs) => js.Call(nameRef(id), vargs.map(toJS) ++ bargs.map(argumentToJS))
     case Pure.PureApp(id, vargs)     => inlineExtern(id, vargs)
     case Pure.Make(data, tag, vargs) => js.New(nameRef(tag), vargs map toJS)
-    case Pure.Box(b)                 => toJS(b)
+    case Pure.Box(b)                 => argumentToJS(b)
   }
 
   def toJS(s: cps.Stmt)(using D: TransformerContext): Binding[List[js.Stmt]] = s match {

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ object TransformerCps extends Transformer {`
`200`	`200`	`case DirectApp(id, vargs, bargs) => js.Call(nameRef(id), vargs.map(toJS) ++ bargs.map(argumentToJS))`
`201`	`201`	`case Pure.PureApp(id, vargs) => inlineExtern(id, vargs)`
`202`	`202`	`case Pure.Make(data, tag, vargs) => js.New(nameRef(tag), vargs map toJS)`
`203`		`- case Pure.Box(b) => toJS(b)`
	`203`	`+ case Pure.Box(b) => argumentToJS(b)`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`def toJS(s: cps.Stmt)(using D: TransformerContext): Binding[List[js.Stmt]] = s match {`