Valgrind fails in CI (#790)

Co-authored-by: Mattis Böckle <[email protected]>

Author: phischu

effekt/jvm/src/main/scala/effekt/Runner.scala

@@ -94,7 +94,7 @@ trait Runner[Executable] {
    */
   def eval(executable: Executable)(using C: Context): Unit = {
     val execFile = build(executable)
-    val valgrindArgs = Seq("--leak-check=full", "--quiet", "--log-file=valgrind.log", "--error-exitcode=1")
+    val valgrindArgs = Seq("--leak-check=full", "--undef-value-errors=no", "--quiet", "--log-file=valgrind.log", "--error-exitcode=1")
     val process = if (C.config.valgrind())
       Process("valgrind", valgrindArgs ++ (execFile +: Context.config.runArgs()))
     else

effekt/jvm/src/test/scala/effekt/LLVMTests.scala

@@ -19,14 +19,6 @@ class LLVMTests extends EffektTests {
     examplesDir / "benchmarks",
   )
 
-  lazy val bugs: List[File] = List(
-    // Jump to the invalid address stated on the next line
-    examplesDir / "benchmarks" / "input_output" / "dyck_one.effekt",
-    examplesDir / "benchmarks" / "input_output" / "number_matrix.effekt",
-    examplesDir / "benchmarks" / "input_output" / "word_count_ascii.effekt",
-    examplesDir / "benchmarks" / "input_output" / "word_count_utf8.effekt",
-  )
-
   /**
    * Documentation of currently failing tests and their reason
    */
@@ -60,5 +52,5 @@ class LLVMTests extends EffektTests {
     examplesDir / "pos" / "issue733.effekt",
   )
 
-  override lazy val ignored: List[File] = bugs ++ missingFeatures
+  override lazy val ignored: List[File] = missingFeatures
 }

effekt/jvm/src/test/scala/effekt/StdlibTests.scala

@@ -40,13 +40,6 @@ class StdlibLLVMTests extends StdlibTests {
   override def debug = sys.env.get("EFFEKT_DEBUG").nonEmpty
 
   override def ignored: List[File] = List(
-    // Syscall param write(buf) points to uninitialised byte(s)
-    examplesDir / "stdlib" / "io" / "filesystem" / "files.effekt",
-    examplesDir / "stdlib" / "io" / "filesystem" / "async_file_io.effekt",
-
-    // Conditional jump or move depends on uninitialised value(s)
-    examplesDir / "stdlib" / "io" / "filesystem" / "wordcount.effekt",
-
     // String comparison using `<`, `<=`, `>`, `>=` is not implemented yet on LLVM
     examplesDir / "stdlib" / "string" / "compare.effekt",
 

libraries/llvm/io.c

@@ -177,11 +177,11 @@ void c_fs_close(Int file, Stack stack) {
 /**
  * Maps the libuv error code to a stable (platform independent) numeric value.
  *
- * Tries to use most common errno integer values, but introduces fresh values (> 200)
- * for those without common errno values.
+ * Tries to use most common error number integer values, but introduces fresh values (> 200)
+ * for those without common error number values.
  */
-Int c_error_number(Int errno) {
-    switch (errno) {
+Int c_error_number(Int error) {
+    switch (error) {
         case UV_EPERM:            return 1;    // EPERM
         case UV_ENOENT:           return 2;    // ENOENT
         case UV_ESRCH:            return 3;    // ESRCH