v1.7.54

Author: efroemling

.efrocachemap

@@ -1,4 +1,4 @@
-### 1.7.54 (build 22632, api 9, 2025-11-19)
+### 1.7.54 (build 22633, api 9, 2025-11-19)
 - `scrollwidget` and `hscrollwidget` now center selected items that are too
   large to fit completely in view instead of unpredictably scrolling to the
   beginning or end of them. This makes show-buffer values (which effectively

CHANGELOG.md

@@ -56,7 +56,7 @@
 
 # Build number and version of the ballistica binary we expect to be
 # using.
-TARGET_BALLISTICA_BUILD = 22632
+TARGET_BALLISTICA_BUILD = 22633
 TARGET_BALLISTICA_VERSION = '1.7.54'
 
 

src/assets/ba_data/python/baenv.py

@@ -146,6 +146,9 @@ def restore_window_shared_state(
         if not isinstance(window.request, dui1.Request):
             return
 
+        # If desired, set the profile button that will be selected in
+        # the new window. We do this when coming back from creating a
+        # new profile/etc.
         if (
             window.request.path == '/'
             and self._next_selected_profile is not None
@@ -157,20 +160,14 @@ def restore_window_shared_state(
             self._next_selected_profile = None
 
     def _on_profile_save(self, name: str) -> None:
+        # An editor we launched tells us it saved a profile.
+
         # Have this one selected when we go back to the listing.
         self._next_selected_profile = name
         bui.pushcall(self._notify_profiles_changed)
 
-    def _notify_profiles_changed(self) -> None:
-        import bascenev1 as bs
-
-        # If there's a team-chooser in existence, tell it the profile-list
-        # has probably changed.
-        session = bs.get_foreground_host_session()
-        if session is not None:
-            session.handlemessage(bs.PlayerProfilesChangedMessage())
-
     def _on_profile_delete(self, name: str) -> None:
+        # An editor we launched tells us it deleted a profile.
 
         # Ask the inventory list to select/show the profile right before
         # the one we're deleting.
@@ -192,6 +189,15 @@ def _on_profile_delete(self, name: str) -> None:
 
         self._notify_profiles_changed()
 
+    def _notify_profiles_changed(self) -> None:
+        import bascenev1 as bs
+
+        # If there's a team-chooser in existence, tell it the profile-list
+        # has probably changed.
+        session = bs.get_foreground_host_session()
+        if session is not None:
+            session.handlemessage(bs.PlayerProfilesChangedMessage())
+
     def _get_profile_buttons(self) -> list[dui1.Button]:
         # pylint: disable=too-many-locals
 
@@ -275,10 +281,6 @@ def _new_profile(self, action: DocUILocalAction) -> None:
 
         bui.getsound('swish').play()
 
-        # No-op if we're not the in-control main window.
-        if not action.window.main_window_has_control():
-            return
-
         plus = bui.app.plus
         assert plus is not None
 
@@ -312,10 +314,6 @@ def _edit_profile(self, action: DocUILocalAction) -> None:
 
         bui.getsound('swish').play()
 
-        # No-op if we're not in control.
-        if not action.window.main_window_has_control():
-            return
-
         profile = action.args.get('profile')
         assert isinstance(profile, str)
 

src/assets/ba_data/python/bauiv1lib/inventory.py

@@ -24,16 +24,6 @@ class EditProfileWindow(
 ):
     """Window for editing a player profile."""
 
-    def reload_window(self) -> None:
-        """Transitions out and recreates ourself."""
-
-        # Replace ourself with ourself, but keep the same back location.
-        assert self.main_window_back_state is not None
-        self.main_window_replace(
-            lambda: EditProfileWindow(self.getname()),
-            back_state=self.main_window_back_state,
-        )
-
     def __init__(
         self,
         existing_profile: str | None,
@@ -43,13 +33,11 @@ def __init__(
         on_profile_save: Callable[[str], None] | None = None,
         on_profile_delete: Callable[[str], None] | None = None,
     ):
-        # FIXME: Tidy this up a bit.
         # pylint: disable=too-many-branches
         # pylint: disable=too-many-statements
         # pylint: disable=too-many-locals
 
         assert bui.app.classic is not None
-        # print(f'EditProfileWindow({id(self)})')
 
         plus = bui.app.plus
         assert plus is not None
@@ -547,6 +535,16 @@ def __init__(
 
         self._update_character()
 
+    def reload_window(self) -> None:
+        """Transitions out and recreates ourself."""
+
+        # Replace ourself with ourself, but keep the same back location.
+        assert self.main_window_back_state is not None
+        self.main_window_replace(
+            lambda: EditProfileWindow(self.getname()),
+            back_state=self.main_window_back_state,
+        )
+
     def _delete_press(self) -> None:
         # pylint: disable=cyclic-import
         from bauiv1lib.confirm import ConfirmWindow
@@ -604,13 +602,17 @@ def get_main_window_state(self) -> bui.MainWindowState:
 
         # Pull things out of self here; if we do it within the lambda
         # we'll keep ourself alive which is bad.
+        on_profile_save = self._on_profile_save
+        on_profile_delete = self._on_profile_delete
 
         existing_profile = self._existing_profile
         return bui.BasicMainWindowState(
             create_call=lambda transition, origin_widget: cls(
                 transition=transition,
                 origin_widget=origin_widget,
                 existing_profile=existing_profile,
+                on_profile_save=on_profile_save,
+                on_profile_delete=on_profile_delete,
             )
         )
 

src/assets/ba_data/python/bauiv1lib/profile/edit.py

@@ -44,7 +44,7 @@ auto main(int argc, char** argv) -> int {
 namespace ballistica {
 
 // These are set automatically via script; don't modify them here.
-const int kEngineBuildNumber = 22632;
+const int kEngineBuildNumber = 22633;
 const char* kEngineVersion = "1.7.54";
 const int kEngineApiVersion = 9;