Scrutinizer report response

Author: ninjapenguin

src/EchoIt/JsonApi/Exception/Validation.php

@@ -20,7 +20,7 @@ class Validation extends Exception
      * @param string                        $message        The Exception message to throw
      * @param int                           $code           The Exception code
      * @param int                           $httpStatusCode HTTP status code which can be used for broken request
-     * @param Illuminate\Support\MessageBag $errors         Validation errors
+     * @param Illuminate\Support\MessageBag $messages       Validation errors
      */
     public function __construct($message = '', $code = 0, $httpStatusCode = 500, ValidationMessages $messages = NULL)
     {
@@ -33,7 +33,7 @@ public function __construct($message = '', $code = 0, $httpStatusCode = 500, Val
     /**
      * This method returns a HTTP response representation of the Exception
      *
-     * @return JsonApi\ErrorResponse
+     * @return JsonApi\MultiErrorResponse
      */
     public function response()
     {

src/EchoIt/JsonApi/Model.php

@@ -127,7 +127,7 @@ public function getResourceType()
      *
      * @param  Array  $values  user passed values (request data)
      *
-     * @return true|Illuminate\Support\MessageBag  True on pass, MessageBag of errors on fail
+     * @return bool|Illuminate\Support\MessageBag  True on pass, MessageBag of errors on fail
      */
     public function validateArray(Array $values)
     {

src/EchoIt/JsonApi/MultiErrorResponse.php

@@ -22,14 +22,16 @@ public function __construct($httpStatusCode, $errorCode, $errorTitle, Validation
     {
         $data = [ 'errors' => [] ];
 
-        foreach ($errors->keys() as $field) {
+        if ($errors) {
+            foreach ($errors->keys() as $field) {
 
-            foreach ($errors->get($field) as $message) {
+                foreach ($errors->get($field) as $message) {
 
-                $data['errors'][] = [ 'status' => $httpStatusCode, 'code' => $errorCode, 'title' =>  'Validation Fail', 'detail' => $message, 'meta' => ['field' => $field] ];
+                    $data['errors'][] = [ 'status' => $httpStatusCode, 'code' => $errorCode, 'title' =>  'Validation Fail', 'detail' => $message, 'meta' => ['field' => $field] ];
 
-            }
+                }
 
+            }
         }
 
         parent::__construct($data, $httpStatusCode);