Skip to content

Commit e08ae36

Browse files
killaguclaude
andcommitted
fix(ci): accept any HTTP response in manifest E2E health check
hello-tegg has no `/` route (only `/hello`), so the health check returns 404. Change the check to accept any HTTP response (status != "000") as proof the app booted successfully. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent e720d3e commit e08ae36

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ecosystem-ci/scripts/verify-manifest.mjs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const projectDir = process.cwd();
1919
const manifestPath = join(projectDir, '.egg', 'manifest.json');
2020
const env = process.env.MANIFEST_VERIFY_ENV || 'unittest';
2121
const healthPort = process.env.MANIFEST_VERIFY_PORT || '7002';
22-
const healthTimeout = parseInt(process.env.MANIFEST_VERIFY_TIMEOUT || '30', 10);
22+
const healthTimeout = parseInt(process.env.MANIFEST_VERIFY_TIMEOUT || '60', 10);
2323

2424
function run(cmd) {
2525
console.log(`\n$ ${cmd}`);
@@ -90,7 +90,9 @@ try {
9090
const output = runCapture(`curl -s -o /dev/null -w "%{http_code}" "${healthUrl}"`);
9191
const status = output.trim();
9292
console.log(' Health check: status=%s', status);
93-
if (status === '200') {
93+
// Any HTTP response (not connection refused) means the app is up.
94+
// Not all apps have a route on `/`, so we accept any status code.
95+
if (status !== '000') {
9496
ready = true;
9597
break;
9698
}
@@ -125,4 +127,4 @@ console.log('\n--- Step 5: Clean manifest ---');
125127
run(`npx egg-bin manifest clean`);
126128
assert(!existsSync(manifestPath), '.egg/manifest.json removed after clean');
127129

128-
console.log('\n=== All manifest E2E checks passed! ===');
130+
console.log('\n=== All manifest E2E checks passed ===');

0 commit comments

Comments
 (0)