Skip to content

Commit fbd6085

Browse files
committed
chore: delete log
1 parent f37770b commit fbd6085

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

test/fixtures/apps/dns_resolver/config/config.default.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,12 @@ exports.httpclient = {
55
const IP_REGEX = /^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/;
66
if (IP_REGEX.test(hostname)) {
77
const family = typeof options.family === 'number' ? options.family : 4;
8-
console.log(
9-
`[dns-resolver] literal IP ${hostname} lookup, bypassing cache`
10-
);
118
if (options.all) {
129
callback(null, [{ address: hostname, family }]);
1310
} else {
1411
callback(null, hostname, family);
1512
}
1613
} else {
17-
console.log(
18-
`[dns-resolver] custom lookup for hostname: ${hostname}`
19-
);
20-
2114
const resultIp = '127.0.0.1'
2215
if (options.all) {
2316
callback(null, [{ address: resultIp, family: 4 }]);

test/lib/core/dns_resolver.test.js

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const startServer = (ip = '127.0.0.1') => {
2121

2222
localServer.listen(0, err => {
2323
if (err) return reject(err);
24-
console.log(`Local test server ${ip} started on port`, localServer.address().port);
2524
return resolve({ url: `http://${ip}:` + localServer.address().port, server: localServer });
2625
});
2726
});
@@ -36,24 +35,30 @@ describe('test/lib/core/dns_resolver.test.js', () => {
3635
let server1;
3736
let server2;
3837

38+
process.once('exit', () => {
39+
if (server1?.server?.close) server1.server.close();
40+
if (server2?.server?.close) server2.server.close();
41+
})
42+
3943
before(async () => {
40-
server1 = await startServer('127.0.0.1')
41-
server2 = await startServer('127.0.0.2')
44+
server1 = await startServer('127.0.0.1');
45+
server2 = await startServer('127.0.0.2');
4246
if (!server1 || !server2) {
4347
throw new Error('start local server failed');
4448
}
45-
process.once('exit', () => {
46-
if (server1 && server1.server) server1.server.close();
47-
if (server2 && server2.server) server2.server.close();
48-
})
4949
app = utils.app('apps/dns_resolver');
5050
await app.ready();
51-
url1 = server1.url
51+
url1 = server1.url;
5252
url1 = url1.replace('127.0.0.1', 'localhost');
53-
url2 = server2.url
53+
url2 = server2.url;
5454
url2 = url2.replace('127.0.0.2', 'localhost');
5555
});
5656

57+
after(() => {
58+
if (server1?.server?.close) server1.server.close();
59+
if (server2?.server?.close) server2.server.close();
60+
})
61+
5762
it('should surpass dns resolve', async () => {
5863
let res = await app.curl(server1.url + '/get_headers', { dataType: 'json' });
5964
assert(res.status === 200);
@@ -76,7 +81,6 @@ describe('test/lib/core/dns_resolver.test.js', () => {
7681
const res = await app.curl(url1 + '/get_headers', { dataType: 'json' });
7782
assert(res.status !== 200);
7883
} catch (err) {
79-
console.error(`\nRequest Error\n`, err.message);
8084
assert(err);
8185
assert(err.message.includes('ECONNREFUSED'));
8286
}
@@ -99,7 +103,6 @@ describe('test/lib/core/dns_resolver.test.js', () => {
99103
const res = await app.fetch(url1 + '/get_headers', { dataType: 'json' });
100104
assert(res.status !== 200);
101105
} catch (err) {
102-
console.error(`\nRequest Error\n`, err.message);
103106
assert(err);
104107
assert(err.message.includes('fetch failed'));
105108
}

0 commit comments

Comments
 (0)