Remove tests and update workflow to trigger only on comment with '@actions-user changelog'

Co-authored-by: saulshanabrook <[email protected]>

Author: Copilot

.github/workflows/update-changelog.yml

@@ -1,25 +1,39 @@
 name: Update Changelog
 
 on:
-  pull_request:
-    types: [opened, edited]
+  issue_comment:
+    types: [created]
 
 jobs:
   update-changelog:
-    # Only run if this is not a PR from a fork to avoid permission issues
-    # and not a commit made by GitHub Action to avoid infinite loops
-    if: github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'github-actions[bot]'
+    # Only run if this is a comment on a PR containing "@actions-user changelog"
+    # and not a comment made by GitHub Action to avoid infinite loops
+    if: github.event.issue.pull_request && contains(github.event.comment.body, '@actions-user changelog') && github.actor != 'github-actions[bot]'
     runs-on: ubuntu-latest
     permissions:
       contents: write
       pull-requests: write
 
     steps:
+      - name: Get PR details
+        id: pr-details
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { data: pullRequest } = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: context.issue.number
+            });
+            core.setOutput('number', pullRequest.number);
+            core.setOutput('title', pullRequest.title);
+            core.setOutput('head_ref', pullRequest.head.ref);
+      
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
           # Checkout the PR head ref
-          ref: ${{ github.event.pull_request.head.ref }}
+          ref: ${{ steps.pr-details.outputs.head_ref }}
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Set up Python
@@ -30,8 +44,8 @@ jobs:
       - name: Update changelog
         run: |
           python modify_changelog.py update_changelog \
-            "${{ github.event.pull_request.number }}" \
-            '${{ github.event.pull_request.title }}'
+            "${{ steps.pr-details.outputs.number }}" \
+            '${{ steps.pr-details.outputs.title }}'
       
       - name: Check for changes
         id: changes
@@ -48,5 +62,5 @@ jobs:
           git config --local user.email "[email protected]"
           git config --local user.name "GitHub Action"
           git add docs/changelog.md
-          git commit -m "Add changelog entry for PR #${{ github.event.pull_request.number }}"
+          git commit -m "Add changelog entry for PR #${{ steps.pr-details.outputs.number }}"
           git push

python/tests/test_modify_changelog.py

@@ -295,102 +295,3 @@ def test_custom_changelog_path():
         # Check changelog was updated
         updated_changelog = custom_changelog_path.read_text()
         assert "- Add new feature [#456](https://github.com/egraphs-good/egglog-python/pull/456)" in updated_changelog
-
-
-def test_update_changelog_with_markdown_backticks():
-    """Test that PR titles with markdown backticks are preserved correctly."""
-    with tempfile.TemporaryDirectory() as temp_dir:
-        temp_path = Path(temp_dir)
-
-        # Create mock changelog
-        changelog_content = """# Changelog
-
-## UNRELEASED
-
-## 1.2.3 (2024-01-01)
-
-- Some old change
-"""
-        docs_dir = temp_path / "docs"
-        docs_dir.mkdir()
-        changelog_path = docs_dir / "changelog.md"
-        changelog_path.write_text(changelog_content)
-
-        # Test with title containing markdown backticks
-        pr_title_with_backticks = "Support methods like `__array_function__` on expressions"
-
-        # Run the script
-        result = subprocess.run(
-            [
-                sys.executable,
-                str(Path(__file__).parent.parent.parent / "modify_changelog.py"),
-                "update_changelog",
-                "315",
-                pr_title_with_backticks,
-            ],
-            capture_output=True,
-            text=True,
-            cwd=temp_path,
-            check=False,
-        )
-
-        assert result.returncode == 0
-        assert f"Added changelog entry for PR #315: {pr_title_with_backticks}" in result.stdout
-
-        # Check that backticks are preserved in the changelog
-        updated_changelog = changelog_path.read_text()
-        expected_entry = f"- {pr_title_with_backticks} [#315](https://github.com/egraphs-good/egglog-python/pull/315)"
-        assert expected_entry in updated_changelog
-        
-        # Specifically check that the backticks around __array_function__ are preserved
-        assert "`__array_function__`" in updated_changelog
-
-
-def test_update_changelog_multiple_backticks():
-    """Test that PR titles with multiple markdown elements are preserved correctly."""
-    with tempfile.TemporaryDirectory() as temp_dir:
-        temp_path = Path(temp_dir)
-
-        # Create mock changelog
-        changelog_content = """# Changelog
-
-## UNRELEASED
-
-## 1.2.3 (2024-01-01)
-
-- Some old change
-"""
-        docs_dir = temp_path / "docs"
-        docs_dir.mkdir()
-        changelog_path = docs_dir / "changelog.md"
-        changelog_path.write_text(changelog_content)
-
-        # Test with title containing multiple markdown elements
-        pr_title_complex = "Fix `__getattr__` and add support for `__setitem__` methods"
-
-        # Run the script
-        result = subprocess.run(
-            [
-                sys.executable,
-                str(Path(__file__).parent.parent.parent / "modify_changelog.py"),
-                "update_changelog",
-                "999",
-                pr_title_complex,
-            ],
-            capture_output=True,
-            text=True,
-            cwd=temp_path,
-            check=False,
-        )
-
-        assert result.returncode == 0
-        assert f"Added changelog entry for PR #999: {pr_title_complex}" in result.stdout
-
-        # Check that all backticks are preserved in the changelog
-        updated_changelog = changelog_path.read_text()
-        expected_entry = f"- {pr_title_complex} [#999](https://github.com/egraphs-good/egglog-python/pull/999)"
-        assert expected_entry in updated_changelog
-        
-        # Specifically check that both sets of backticks are preserved
-        assert "`__getattr__`" in updated_changelog
-        assert "`__setitem__`" in updated_changelog