Skip to content

Conversation

@saulshanabrook
Copy link
Member

Adds support for upstream egglog change to emit when serializing and functions or calls were omitted based on maxmimums

Adds support for upstream egglog change to emit when serializing and
functions or calls were omitted based on maxmimums
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds warning support when visualizing egglog graphs to alert users when functions or calls are omitted due to maximum limits. This provides better feedback about incomplete visualizations.

  • Implements warning emission when functions are discarded or truncated during serialization
  • Adds helper method to map egglog function names to Python function names for clearer warnings
  • Includes tests to verify warning behavior for both max_functions and max_calls_per_function limits

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
python/egglog/egraph_state.py Adds possible_egglog_functions method to map egglog function names to Python function strings
python/egglog/egraph.py Integrates warning emission in _serialize method when functions are discarded or truncated
python/tests/test_high_level.py Adds test cases to verify warning behavior for serialization limits

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@saulshanabrook
Copy link
Member Author

@actions-user changelog

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 1, 2025

CodSpeed Instrumentation Performance Report

Merging #336 will not alter performance

Comparing warning-viz (6586a4b) with main (0fc9674)

Summary

✅ 7 untouched benchmarks

@saulshanabrook saulshanabrook merged commit f8d552c into main Sep 1, 2025
5 checks passed
@saulshanabrook saulshanabrook deleted the warning-viz branch September 1, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants