From 73e5cb330cbfad10d419485a232f29d876ae69d0 Mon Sep 17 00:00:00 2001 From: Saul Shanabrook Date: Mon, 5 May 2025 05:47:48 -0400 Subject: [PATCH] Fix tests not running on different Python version Try to fix the CI tests by running properly on different Python versions. Found by https://github.com/egraphs-good/egglog-python/issues/295 --- .github/workflows/CI.yml | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7468e086..d0f58e0f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -26,15 +26,12 @@ jobs: - "3.10" steps: - uses: actions/checkout@v4 - - uses: astral-sh/setup-uv@v5 + - uses: astral-sh/setup-uv@v6 with: enable-cache: true + python-version: ${{ matrix.py }} - uses: dtolnay/rust-toolchain@1.79.0 - uses: Swatinem/rust-cache@v2 - - name: Setup python ${{ matrix.py }} - uses: actions/setup-python@v5 - with: - python-version: ${{ matrix.py }} - run: uv sync --extra test --locked - run: uv run pytest --benchmark-disable -vvv --durations=10 @@ -42,15 +39,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: astral-sh/setup-uv@v5 + - uses: astral-sh/setup-uv@v6 with: enable-cache: true - - uses: dtolnay/rust-toolchain@1.79.0 - - uses: Swatinem/rust-cache@v2 - - uses: actions/setup-python@v5 - with: # Run on oldest Python version to catch more errors python-version: "3.10" + - uses: dtolnay/rust-toolchain@1.79.0 + - uses: Swatinem/rust-cache@v2 - run: uv sync --extra test --locked - run: make mypy - run: make stubtest @@ -59,14 +54,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: astral-sh/setup-uv@v5 + - uses: astral-sh/setup-uv@v6 with: enable-cache: true - uses: dtolnay/rust-toolchain@1.79.0 - uses: Swatinem/rust-cache@v2 - - uses: actions/setup-python@v5 - with: - python-version-file: ".python-version" - run: uv sync --extra test --locked - uses: CodSpeedHQ/action@v3 with: @@ -78,14 +70,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: astral-sh/setup-uv@v5 + - uses: astral-sh/setup-uv@v6 with: enable-cache: true - uses: dtolnay/rust-toolchain@1.79.0 - uses: Swatinem/rust-cache@v2 - - uses: actions/setup-python@v5 - with: - python-version-file: ".python-version" - name: Install graphviz run: | sudo apt-get update