Skip to content

Commit e260639

Browse files
mconcasdavidrohr
authored andcommitted
ITSGPU: disable linter for false positive in CUB calls
Reported `0`s are detected as to be used as `nullptr`. This is wrong. See also the signature here: https://rocm.docs.amd.com/projects/hipCUB/en/docs-5.7.0/.doxygen/docBin/html/classhipcub_1_1DeviceScan.html
1 parent 1a86fd1 commit e260639

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Detectors/ITSMFT/ITS/tracking/GPU/cuda/TrackingKernels.cu

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -842,14 +842,14 @@ void countCellsHandler(
842842
cellsLUTsHost, // d_in
843843
cellsLUTsHost, // d_out
844844
nTracklets + 1, // num_items
845-
0));
845+
0)); // NOLINT: this is the offset of the sum, not a pointer
846846
discardResult(cudaMalloc(&d_temp_storage, temp_storage_bytes));
847847
gpuCheckError(cub::DeviceScan::ExclusiveSum(d_temp_storage, // d_temp_storage
848848
temp_storage_bytes, // temp_storage_bytes
849849
cellsLUTsHost, // d_in
850850
cellsLUTsHost, // d_out
851851
nTracklets + 1, // num_items
852-
0));
852+
0)); // NOLINT: this is the offset of the sum, not a pointer
853853
// gpu::printBufferLayerOnThread<<<1, 1>>>(layer, cellsLUTsHost, nTracklets + 1);
854854
gpuCheckError(cudaFree(d_temp_storage));
855855
}
@@ -934,14 +934,14 @@ void countCellNeighboursHandler(CellSeed** cellsLayersDevice,
934934
neighboursIndexTable, // d_in
935935
neighboursIndexTable, // d_out
936936
nCells + 1, // num_items
937-
0));
937+
0)); // NOLINT: this is the offset of the sum, not a pointer
938938
discardResult(cudaMalloc(&d_temp_storage_2, temp_storage_bytes_2));
939939
gpuCheckError(cub::DeviceScan::ExclusiveSum(d_temp_storage_2, // d_temp_storage
940940
temp_storage_bytes_2, // temp_storage_bytes
941941
neighboursIndexTable, // d_in
942942
neighboursIndexTable, // d_out
943943
nCells + 1, // num_items
944-
0));
944+
0)); // NOLINT: this is the offset of the sum, not a pointer
945945
gpuCheckError(cudaFree(d_temp_storage));
946946
gpuCheckError(cudaFree(d_temp_storage_2));
947947
gpuCheckError(cudaPeekAtLastError());
@@ -1032,4 +1032,4 @@ void trackSeedHandler(CellSeed* trackSeeds,
10321032
gpuCheckError(cudaPeekAtLastError());
10331033
gpuCheckError(cudaDeviceSynchronize());
10341034
}
1035-
} // namespace o2::its
1035+
} // namespace o2::its

0 commit comments

Comments
 (0)