Skip to content

Commit 57415f9

Browse files
committed
Remove rejectionWarning logic
It's due to a bug introduced in Node 12.6.0 but fixed in 12.7.0 nodejs/node#28540
1 parent 712074c commit 57415f9

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

src/handle/common.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { isLimited } from '../limit.js'
22
import { isRepeated } from '../repeat.js'
3-
import { isRejectionWarning } from '../warnings.js'
43
import { getLevel } from '../level.js'
54
import { getError, addErrorPrint } from '../error/main.js'
65
import { exitProcess } from '../exit.js'
@@ -34,10 +33,6 @@ export const handleEvent = async function({
3433
return
3534
}
3635

37-
if (isRejectionWarning(name, event)) {
38-
return
39-
}
40-
4136
await logEvent({ opts, name, event })
4237

4338
await exitProcess({ name, opts })

src/warnings.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,3 @@ const getWarningListeners = function() {
4646
}
4747

4848
const warningListener = getWarningListener()
49-
50-
// Unhandled rejected promises emit a warning by default (unless
51-
// --unhandled-rejections is used). This warning is not useful, so we remove it.
52-
export const isRejectionWarning = function(name, { value }) {
53-
return (
54-
name === 'warning' &&
55-
value instanceof Error &&
56-
value.name === 'DeprecationWarning' &&
57-
value.code === 'DEP0018'
58-
)
59-
}

0 commit comments

Comments
 (0)