Remove multipleResolves

Author: ehmicky

README.md

@@ -21,9 +21,6 @@ on the console which is very useful. Unfortunately those errors:
   [`warning`](https://nodejs.org/api/process.html#process_event_warning) and
   [`rejectionHandled`](https://nodejs.org/api/process.html#process_event_rejectionhandled)
   making them hard to debug.
-- do not include
-  [`multipleResolves`](https://nodejs.org/api/process.html#process_event_multipleresolves)
-  errors (when a promise is resolved/rejected twice).
 - are inconvenient to [log to an external service](docs/API.md#log).
 - are hard to [test](docs/API.md#testing).
 - cannot be conditionally skipped.
@@ -101,7 +98,7 @@ Customizes how process errors are logged.\
 ## level
 
 _Type_: `object`\
-_Default_: `{ warning: 'warn', multipleResolves: 'info', default: 'error' }`
+_Default_: `{ warning: 'warn', default: 'error' }`
 
 Which log level to use.\
 [Full documentation](docs/API.md#level).

docs/API.md

@@ -28,7 +28,7 @@ logProcessErrors({
     winstonLogger[level](error.stack)
   },
 
-  level: { multipleResolves: 'debug' },
+  level: { uncaughtException: 'debug' },
 
   exitOn: ['uncaughtException', 'unhandledRejection'],
 
@@ -75,16 +75,15 @@ defined or not).
 #### level
 
 _Type_: `object`\
-_Default_: `{ warning: 'warn', multipleResolves: 'info', default: 'error' }`
+_Default_: `{ warning: 'warn', default: 'error' }`
 
 Which log level to use.
 
 Object keys are the error names:
 [`uncaughtException`](https://nodejs.org/api/process.html#process_event_uncaughtexception),
 [`warning`](https://nodejs.org/api/process.html#process_event_warning),
 [`unhandledRejection`](https://nodejs.org/api/process.html#process_event_unhandledrejection),
-[`rejectionHandled`](https://nodejs.org/api/process.html#process_event_rejectionhandled),
-[`multipleResolves`](https://nodejs.org/api/process.html#process_event_multipleresolves)
+[`rejectionHandled`](https://nodejs.org/api/process.html#process_event_rejectionhandled)
 or `default`.
 
 Object values are the log level: `'debug'`, `'info'`, `'warn'`, `'error'`,
@@ -96,8 +95,8 @@ import logProcessErrors from 'log-process-errors'
 
 logProcessErrors({
   level: {
-    // Use `debug` log level for `multipleResolves` instead of `info`
-    multipleResolves: 'debug',
+    // Use `debug` log level for `uncaughtException` instead of `error`
+    uncaughtException: 'debug',
 
     // Skip some logs based on a condition
     default(error) {
@@ -112,8 +111,7 @@ logProcessErrors({
 _Type_: `string[]`\
 _Value_: array of [`'uncaughtException'`](https://nodejs.org/api/process.html#process_event_uncaughtexception),
 [`'unhandledRejection'`](https://nodejs.org/api/process.html#process_event_unhandledrejection),
-[`'rejectionHandled'`](https://nodejs.org/api/process.html#process_event_rejectionhandled),
-[`'multipleResolves'`](https://nodejs.org/api/process.html#process_event_multipleresolves)
+[`'rejectionHandled'`](https://nodejs.org/api/process.html#process_event_rejectionhandled)
 or [`'warning'`](https://nodejs.org/api/process.html#process_event_warning)\
 _Default_: `['uncaughtException', 'unhandledRejection']` for Node `>= 15.0.0`,
 `['uncaughtException']` otherwise.
@@ -209,8 +207,7 @@ available as a third argument to [`log`](#log).
 _Type_: `string`\
 _Value_: [`'UncaughtException'`](https://nodejs.org/api/process.html#process_event_uncaughtexception),
 [`'UnhandledRejection'`](https://nodejs.org/api/process.html#process_event_unhandledrejection),
-[`'RejectionHandled'`](https://nodejs.org/api/process.html#process_event_rejectionhandled),
-[`'MultipleResolves'`](https://nodejs.org/api/process.html#process_event_multipleresolves)
+[`'RejectionHandled'`](https://nodejs.org/api/process.html#process_event_rejectionhandled)
 or [`'Warning'`](https://nodejs.org/api/process.html#process_event_warning)
 
 #### error.stack

examples/after.js

@@ -7,12 +7,7 @@
 
 import logProcessErrors from 'log-process-errors'
 
-import {
-  uncaughtException,
-  unhandledRejection,
-  warning,
-  multipleResolves,
-} from './errors.js'
+import { uncaughtException, unhandledRejection, warning } from './errors.js'
 
 // Initialization
 logProcessErrors()
@@ -21,4 +16,3 @@ logProcessErrors()
 uncaughtException()
 unhandledRejection()
 warning()
-multipleResolves()

examples/before.js

@@ -6,15 +6,9 @@
 // An online demo is also available at:
 //   https://repl.it/@ehmicky/log-process-errors
 
-import {
-  uncaughtException,
-  unhandledRejection,
-  warning,
-  multipleResolves,
-} from './errors.js'
+import { uncaughtException, unhandledRejection, warning } from './errors.js'
 
 // Emit different types of process errors.
 uncaughtException()
 unhandledRejection()
 warning()
-multipleResolves()

examples/errors.js

@@ -26,12 +26,3 @@ export const warning = function () {
     detail: 'opts.force is deprecated',
   })
 }
-
-// Emit a `multipleResolves` event
-export const multipleResolves = function () {
-  // eslint-disable-next-line promise/avoid-new
-  return new Promise((resolve, reject) => {
-    resolve({ success: true })
-    reject(new Error('Cannot send request'))
-  })
-}

examples/level.js

@@ -7,14 +7,14 @@
 
 import logProcessErrors from 'log-process-errors'
 
-import { multipleResolves, warning } from './errors.js'
+import { warning, uncaughtException } from './errors.js'
 
 // Initialization
 // Changes which log level to use
 logProcessErrors({
   level: {
-    // Use `debug` log level for `multipleResolves` instead of `info`
-    multipleResolves: 'debug',
+    // Use `debug` log level for `uncaughtException` instead of `error`
+    uncaughtException: 'debug',
 
     // Skip some logs based on a condition
     default(error) {
@@ -31,5 +31,5 @@ const shouldSkip = function ({ message }) {
 // This deprecation `warning` will be silent
 warning()
 
-// This `multipleResolves` process error will use a `debug` log level
-multipleResolves()
+// This `uncaughtException` process error will use a `debug` log level
+uncaughtException()

package.json

@@ -28,7 +28,6 @@
     "uncaughtException",
     "unhandledRejection",
     "rejectionHandled",
-    "multipleResolves",
     "debugging",
     "testing",
     "test"

src/error/message.js

@@ -33,35 +33,11 @@ const rejectionHandled = function ({ value }) {
   return `a promise was rejected and handled too late: ${serialize(value)}`
 }
 
-// The default level is `event` because it does not always indicate an error:
-// https://github.com/nodejs/node/issues/24321
-const multipleResolves = function ({
-  rejected,
-  value,
-  nextRejected,
-  nextValue,
-}) {
-  const rejectedStr = REJECTED_NAME[rejected]
-  const nextRejectedStr = REJECTED_NAME[nextRejected]
-  const again = rejected === nextRejected ? ' again' : ''
-  const state = again ? rejectedStr : 'resolved/rejected'
-
-  return `a promise was ${state} multiple times:
-Initially ${rejectedStr} with: ${serialize(value)}
-Then ${nextRejectedStr}${again} with: ${serialize(nextValue)}`
-}
-
-const REJECTED_NAME = {
-  true: 'rejected',
-  false: 'resolved',
-}
-
 const MESSAGES = {
   uncaughtException,
   warning,
   unhandledRejection,
   rejectionHandled,
-  multipleResolves,
 }
 
 // We use `util.inspect()` instead of `JSON.stringify()` or a third-party

src/exit.js

@@ -56,7 +56,6 @@ const EVENTS_ARR = [
   'uncaughtException',
   'unhandledRejection',
   'rejectionHandled',
-  'multipleResolves',
   'warning',
 ]
 const EVENTS = new Set(EVENTS_ARR)

src/handle/event.js

@@ -47,7 +47,7 @@ const NO_PROMISE_EVENTS = new Set([
   'unhandledRejection',
 ])
 
-// `rejectionHandled` and `multipleResolves` otherwise use `await promise`
+// `rejectionHandled` otherwise use `await promise`
 const getPromiseValue = async function ({ promise }) {
   try {
     return { rejected: false, value: await promise }