Do not make tests fail on multipleResolves events with the testing option

Author: ehmicky

src/options/runners.js

@@ -30,7 +30,11 @@ const COMMON_OPTIONS = {
   exitOn: [],
   // All runners need to report `uncaughtException` for
   // `throwUncaughtException()` to work. Most also report `unhandledRejection`.
-  level: { uncaughtException: 'silent', unhandledRejection: 'silent' },
+  level: {
+    uncaughtException: 'silent',
+    unhandledRejection: 'silent',
+    multipleResolves: 'silent',
+  },
 }
 
 export const RUNNERS = {

test/options/snapshots/testing.js.md

@@ -634,41 +634,26 @@ Generated by [AVA](https://ava.li).
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `√ should make tests fail on multipleResolves␊
       ␊
-        Uncaught exception in   MultipleResolves: a promise was  multiple times:␊
-        Initially resolved with: { success: true }␊
-        Then rejected with: Error: message␊
-      ␊
-        ×  exited with a non-zero exit code: 1␊
-      ␊
-        1 test passed␊
-        1 uncaught exception`,
+        1 test passed`,
     }
 
 ## should make tests fails | multipleResolves jasmine
 
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `Randomized with seed 0␊
       Started␊
       .␊
       ␊
       ␊
-      Suite error: should make tests fail␊
-        Message:␊
-          Uncaught exception: MultipleResolves: a promise was  multiple times:␊
-          Initially resolved with: { success: true }␊
-          Then rejected with: Error: message␊
-        Stack:␊
-              at STACK TRACE␊
-      ␊
-      1 spec, 1 failure␊
+      1 spec, 0 failures␊
       Finished in ␊
       Randomized with seed 0 (jasmine --random=true --seed=0)`,
     }
@@ -701,44 +686,20 @@ Generated by [AVA](https://ava.li).
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `TAP version 13␊
-      not ok 1 -  # ␊
-        ---␊
-        env: {}␊
-        file:   timeout: 30000␊
-        command:   args:␊
-          - -r␊
-          -     -   stdio:␊
-          - 0␊
-          - pipe␊
-          - 2␊
-        cwd:   exitCode: 1␊
-        ...␊
-      {␊
+      ok 1 -  #  {␊
           # Subtest: should make tests fail on multipleResolves␊
               1..1␊
               ok 1 - (unnamed test)␊
           ok 1 - should make tests fail on multipleResolves # ␊
           ␊
-          not ok 2 - a promise was  multiple times: Initially resolved with: { success: true } Then rejected with: Error: message␊
-            ---␊
-            stack: |␊
-              Then rejected with: Error: message␊
-                  STACK TRACE␊
-            type: MultipleResolves␊
-            tapCaught: uncaughtException␊
-            test: TAP␊
-            ...␊
-          ␊
-          1..2␊
-          # failed 1 of 2 tests␊
+          1..1␊
           # ␊
       }␊
       ␊
       1..1␊
-      # failed 1 test␊
       # `,
     }
 
@@ -747,23 +708,20 @@ Generated by [AVA](https://ava.li).
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `TAP version 13␊
-      not ok 1 -  #  {␊
+      ok 1 -  #  {␊
           # Subtest: should make tests fail on multipleResolves␊
               1..1␊
               ok 1 - (unnamed test)␊
           ok 1 - should make tests fail on multipleResolves # ␊
           ␊
-          not ok 2 - a promise was  multiple times: Initially resolved with: { success: true } Then rejected with: Error: message␊
-          1..2␊
-          # failed 1 of 2 tests␊
+          1..1␊
           # ␊
       }␊
       ␊
       1..1␊
-      # failed 1 test␊
       # `,
     }
 
@@ -1445,41 +1403,26 @@ Generated by [AVA](https://ava.li).
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `√ should make tests fail on multipleResolves␊
       ␊
-        Uncaught exception in   MultipleResolves: a promise was  multiple times:␊
-        Initially resolved with: { success: true }␊
-        Then rejected with: Error: message␊
-      ␊
-        ×  exited with a non-zero exit code: 1␊
-      ␊
-        1 test passed␊
-        1 uncaught exception`,
+        1 test passed`,
     }
 
 ## should work with the -r flag | multipleResolves jasmine
 
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `Randomized with seed 0␊
       Started␊
       .␊
       ␊
       ␊
-      Suite error: should make tests fail␊
-        Message:␊
-          Uncaught exception: MultipleResolves: a promise was  multiple times:␊
-          Initially resolved with: { success: true }␊
-          Then rejected with: Error: message␊
-        Stack:␊
-              at STACK TRACE␊
-      ␊
-      1 spec, 1 failure␊
+      1 spec, 0 failures␊
       Finished in ␊
       Randomized with seed 0 (jasmine --random=true --seed=0)`,
     }
@@ -1512,44 +1455,20 @@ Generated by [AVA](https://ava.li).
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `TAP version 13␊
-      not ok 1 -  # ␊
-        ---␊
-        env: {}␊
-        file:   timeout: 30000␊
-        command:   args:␊
-          - -r␊
-          -     -   stdio:␊
-          - 0␊
-          - pipe␊
-          - 2␊
-        cwd:   exitCode: 1␊
-        ...␊
-      {␊
+      ok 1 -  #  {␊
           # Subtest: should make tests fail on multipleResolves␊
               1..1␊
               ok 1 - (unnamed test)␊
           ok 1 - should make tests fail on multipleResolves # ␊
           ␊
-          not ok 2 - a promise was  multiple times: Initially resolved with: { success: true } Then rejected with: Error: message␊
-            ---␊
-            stack: |␊
-              Then rejected with: Error: message␊
-                  STACK TRACE␊
-            type: MultipleResolves␊
-            tapCaught: uncaughtException␊
-            test: TAP␊
-            ...␊
-          ␊
-          1..2␊
-          # failed 1 of 2 tests␊
+          1..1␊
           # ␊
       }␊
       ␊
       1..1␊
-      # failed 1 test␊
       # `,
     }
 
@@ -1558,23 +1477,20 @@ Generated by [AVA](https://ava.li).
 > Snapshot 1
 
     {
-      exitCode: 1,
+      exitCode: 0,
       stderr: '',
       stdout: `TAP version 13␊
-      not ok 1 -  #  {␊
+      ok 1 -  #  {␊
           # Subtest: should make tests fail on multipleResolves␊
               1..1␊
               ok 1 - (unnamed test)␊
           ok 1 - should make tests fail on multipleResolves # ␊
           ␊
-          not ok 2 - a promise was  multiple times: Initially resolved with: { success: true } Then rejected with: Error: message␊
-          1..2␊
-          # failed 1 of 2 tests␊
+          1..1␊
           # ␊
       }␊
       ␊
       1..1␊
-      # failed 1 test␊
       # `,
     }