Skip to content

Commit 1a71aa1

Browse files
committed
Fill 'open_item_id' in 'acc_trans' table for ar/ap items
1 parent f2bfb6d commit 1a71aa1

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

old/lib/LedgerSMB/AA.pm

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -302,11 +302,11 @@ sub post_transaction {
302302
$sth = $dbh->prepare($query);
303303
$sth->execute( $form->{employee_id}, $form->{"$form->{vc}_id"}) || $form->dberror($query);
304304

305-
$query = qq|SELECT id FROM $table WHERE invnumber = '$uid'|;
305+
$query = qq|SELECT id, open_item_id FROM $table WHERE invnumber = '$uid'|;
306306
$sth = $dbh->prepare($query);
307307
$sth->execute || $form->dberror($query);
308308

309-
( $form->{id} ) = $sth->fetchrow_array;
309+
( $form->{id}, $form->{open_item_id} ) = $sth->fetchrow_array;
310310

311311
$query = <<~'SQL';
312312
UPDATE transactions
@@ -511,13 +511,13 @@ sub post_transaction {
511511
($accno) = split /--/, $form->{$ARAP};
512512
$query = qq|
513513
INSERT INTO acc_trans
514-
(trans_id, chart_id, amount_bc, curr, amount_tc,
515-
transdate, approved)
514+
(trans_id, chart_id, open_item_id,
515+
amount_bc, curr, amount_tc, transdate, approved)
516516
VALUES (?, (SELECT id FROM account
517-
WHERE accno = ?),
517+
WHERE accno = ?), ?,
518518
?, ?, ?, ?, ?)|;
519519
@queryargs =
520-
( $form->{id}, $accno,
520+
( $form->{id}, $accno, $form->{open_item_id},
521521
$invamount * -1 * $ml, $form->{currency},
522522
$invamount * -1 * $ml / $form->{exchangerate},
523523
$form->{transdate},

old/lib/LedgerSMB/Form.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1992,7 +1992,7 @@ sub create_links {
19921992
txn.approved, ctf.default_reportable,
19931993
txn.description, a.on_hold, a.crdate,
19941994
a.shipto as shiptolocationid, a.shipto_attn as shiptoattn,
1995-
a.is_return, $seq,
1995+
a.is_return, $seq, a.open_item_id,
19961996
t.workflow_id, t.reversing, t.reversing_reference,
19971997
t.reversed_by, t.reversed_by_reference
19981998
FROM $arap a

old/lib/LedgerSMB/IR.pm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,11 @@ sub post_invoice {
150150
$sth = $dbh->prepare($query);
151151
$sth->execute( $form->{employee_id}, $form->{vendor_id}) || $form->dberror($query);
152152

153-
$query = qq|SELECT id FROM ap WHERE invnumber = '$uid'|;
153+
$query = qq|SELECT id, open_item_id FROM ap WHERE invnumber = '$uid'|;
154154
$sth = $dbh->prepare($query);
155155
$sth->execute || $form->dberror($query);
156156

157-
( $form->{id} ) = $sth->fetchrow_array;
157+
( $form->{id}, $form->{open_item_id} ) = $sth->fetchrow_array;
158158

159159
$query = q|UPDATE transactions SET workflow_id = ?, reversing = ? WHERE id = ? AND workflow_id IS NULL|;
160160
$sth = $dbh->prepare($query);
@@ -466,13 +466,13 @@ sub post_invoice {
466466
($accno) = split /--/, $form->{AP};
467467

468468
$query = qq|
469-
INSERT INTO acc_trans (trans_id, chart_id,
469+
INSERT INTO acc_trans (trans_id, chart_id, open_item_id,
470470
amount_bc, curr, amount_tc, transdate, approved)
471-
VALUES (?, (SELECT id FROM account WHERE accno = ?),
471+
VALUES (?, (SELECT id FROM account WHERE accno = ?), ?,
472472
?, ?, ?, ?, ?)|;
473473
$sth = $dbh->prepare($query)
474474
or $form->dberror($dbh->errstr);
475-
$sth->execute( $form->{id}, $accno,
475+
$sth->execute( $form->{id}, $accno, $form->{open_item_id},
476476
$form->{payables}, $form->{currency},
477477
$form->{payables}/$form->{exchangerate},
478478
$form->{transdate}, $approved)

old/lib/LedgerSMB/IS.pm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -805,11 +805,11 @@ sub post_invoice {
805805
$sth = $dbh->prepare($query);
806806
$sth->execute( $form->{employee_id}, $form->{customer_id}) || $form->dberror($query);
807807

808-
$query = qq|SELECT id FROM ar WHERE invnumber = '$uid'|;
808+
$query = qq|SELECT id, open_item_id FROM ar WHERE invnumber = '$uid'|;
809809
$sth = $dbh->prepare($query);
810810
$sth->execute || $form->dberror($query);
811811

812-
( $form->{id} ) = $sth->fetchrow_array;
812+
( $form->{id}, $form->{open_item_id} ) = $sth->fetchrow_array;
813813

814814
$query = q|UPDATE transactions SET workflow_id = ?, reversing = ? WHERE id = ? AND workflow_id IS NULL|;
815815
$sth = $dbh->prepare($query);
@@ -1149,14 +1149,14 @@ sub post_invoice {
11491149

11501150
$query = qq|
11511151
INSERT INTO acc_trans
1152-
(trans_id, chart_id,
1152+
(trans_id, chart_id, open_item_id,
11531153
amount_bc, curr, amount_tc, transdate, approved)
1154-
VALUES (?, (SELECT id FROM account WHERE accno = ?),
1154+
VALUES (?, (SELECT id FROM account WHERE accno = ?), ?,
11551155
?, ?, ?, ?, ?)|;
11561156

11571157
$sth = $dbh->prepare($query)
11581158
or $form->dberror($dbh->errstr);
1159-
$sth->execute( $form->{id}, $accno,
1159+
$sth->execute( $form->{id}, $accno, $form->{open_item_id},
11601160
$form->{receivables}, $form->{currency},
11611161
$form->{receivables} / $form->{exchangerate},
11621162
$transdate, $approved)

0 commit comments

Comments
 (0)