Skip to content

Commit 018c1e8

Browse files
authored
fix: remove SIO from CMake since version number too large (#177)
### Briefly, what does this PR introduce? Please link to any relevant presentations or discussions. This PR removes the SIO support again since apparently it only supports a short int as version number, and we're using major * 10000 + minor * 100 + patch, which overflows. See https://github.com/AIDASoft/podio/actions/runs/32156321288/job/95774482712?pr=1004. ### What is the urgency of this PR? - [x] High (please describe reason below) - [ ] Medium - [ ] Low This currently breaks podio main branch CI workflows. ### What kind of change does this PR introduce? - [x] Bug fix (issue: https://github.com/AIDASoft/podio/actions/runs/32156321288/job/95774482712?pr=1004) - [ ] New datatype (issue #__) - [ ] Change to existing datatype (issue #__) - [ ] Optimization (issue #__) - [ ] Updated documentation - [ ] other: __ ### Please check if any of the following apply - [ ] This PR introduces breaking changes. Please describe changes users need to make below. - [ ] This PR changes default behavior. Please describe changes below. - [ ] AI was used in preparing this PR. Please describe usage below.
1 parent 63b73f8 commit 018c1e8

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,6 @@ add_subdirectory(test)
9292

9393
list(APPEND EDM4EIC_INSTALL_LIBS edm4eic edm4eicDict)
9494

95-
PODIO_ADD_SIO_IO_BLOCKS(edm4eic "${headers}" "${sources}")
96-
if(TARGET edm4eicSioBlocks)
97-
message(STATUS "Building and installing the SioBlocks since podio supports it")
98-
list(APPEND EDM4EIC_INSTALL_LIBS edm4eicSioBlocks)
99-
endif()
100-
10195
if(PODIO_ENABLE_ARROW)
10296
PODIO_ADD_ARROW(edm4eic "${headers}" "${sources}")
10397
message(STATUS "Building and installing the Arrow component since podio supports it")

0 commit comments

Comments
 (0)