Skip to content

Commit 6dca224

Browse files
authored
Remove irrelevant comment for edm4eic::ReconstructedParticle::PDG (#124)
The PDG field was always there: https://github.com/key4hep/EDM4hep/blob/f5ee28748cad196b794fd7c84af2d1660dce3684/edm4hep.yaml#L557 There is no deviation, if we don't like the field we should just remove it.
1 parent b3faa6f commit 6dca224

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

edm4eic.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,6 @@ datatypes:
240240
- float mass // [GeV] mass of the reconstructed particle, set independently from four vector. Four momentum state is not kept consistent internally.
241241
- float goodnessOfPID // overall goodness of the PID on a scale of [0;1]
242242
- edm4eic::Cov4f covMatrix // covariance matrix of the reconstructed particle 4vector (10 parameters).
243-
##@TODO: deviation from EDM4hep: store explicit PDG ID here. Needs to be discussed how we
244-
## move forward as this could easiliy become unwieldy without this information here.
245-
## The only acceptable alternative would be to store reconstructed identified
246-
## particles in separate collections for the different particle types (which would
247-
## require some algorithmic changes but might work. Doing both might even make
248-
## sense. Needs some discussion, note that PID is more emphasized in NP than
249-
## HEP).
250243
- int32_t PDG // PDG code for this particle
251244
## @TODO: Do we need timing info? Or do we rely on the start vertex time?
252245
OneToOneRelations:

0 commit comments

Comments
 (0)