Commit 98bbbd3
authored
fix: allow deprecating surface.associatedDetectorElement in Acts v45 (#2466)
### Briefly, what does this PR introduce?
This PR removes the use of deprecated
`surface.associatedDetectorElement` when in Acts v45
(acts-project/acts#5005). Before Acts v45 this
didn't exist, so no roll-out possible for currently-used Acts versions.
Note that in my testing this is more than just a replacement of one
deprecated call with another with equal functionality. In addition to a
deprecation warning during compilation, this change is also required to
avoid a crash on nullptr surfaces in Acts v45, so it is necessary in
addition to advisable.
### What kind of change does this PR introduce?
- [x] Bug fix (issue: deprecated `surface.associatedDetectorElement`,
fix crash due to nullptr surfaces)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __
### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators
### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.
### Does this PR change default behavior?
No.1 parent e69bd9d commit 98bbbd3
1 file changed
+10
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
103 | 107 | | |
104 | 108 | | |
| 109 | + | |
105 | 110 | | |
106 | 111 | | |
107 | 112 | | |
| |||
166 | 171 | | |
167 | 172 | | |
168 | 173 | | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
169 | 178 | | |
170 | 179 | | |
| 180 | + | |
171 | 181 | | |
172 | 182 | | |
173 | 183 | | |
| |||
0 commit comments