Run plugin suite_finished handler before upload#82
Open
andmat900 wants to merge 5 commits intoeiffel-community:mainfrom
Open
Run plugin suite_finished handler before upload#82andmat900 wants to merge 5 commits intoeiffel-community:mainfrom
andmat900 wants to merge 5 commits intoeiffel-community:mainfrom
Conversation
t-persson
requested changes
Apr 1, 2026
t-persson
approved these changes
Apr 2, 2026
t-persson
requested changes
Apr 2, 2026
Collaborator
t-persson
left a comment
t-persson
left a comment
There was a problem hiding this comment.
Accidentally set approved when I had a comment.
Change-Id: I28dc8a64af90a5e93c4fa5070e787ef517f9193c Signed-off-by: Andrei Matveyeu <andreimu@axis.com>
Change-Id: I3de8a51f19740f984841cdd0bf2a6ffce51e5b9b Signed-off-by: Andrei Matveyeu <andreimu@axis.com>
Change-Id: Iff18d474ab3a5b1cb6a08a2765efdc4cd27adcc4 Signed-off-by: Andrei Matveyeu <andreimu@axis.com>
Change-Id: I22244003c771765710533b8b5ccbcb9705cea786 Signed-off-by: Andrei Matveyeu <andreimu@axis.com>
Change-Id: I3d2ec37f14457fd7c63f3c94471c0576d6846ec0 Signed-off-by: Andrei Matveyeu <andreimu@axis.com>
andmat900
force-pushed
the
20260330_fix_plugin_suite_finished_timing
branch
from
c3eda85 to
f3186e6
Compare
t-persson
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes eiffel-community/etos#504
Description of the Change
Move the
on_test_suite_finishedplugin handler call to run before the Workspace context manager exits, which is where artifact upload happens. Previously the handler ran after artifacts were already uploaded, so plugins that needed to create additional artifacts upon suite completion had to handle upload themselves. Now plugins can simply write files to the artifact directory and they will be uploaded automatically.Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, andreimu@axis.com